-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lower case G-commands not visualized on screen, the g-code is loaded and runs #177
Comments
I have seen other CNC machines that were case sensitive like this, so while I
agree it would be good to make sure we aren't, it's not uncommon to be.
David Lang
…On Thu, 6 Aug 2020, Gero wrote:
Getting Webcontrol to run on my Ubuntu (fake servo to play, research and understand, I noticed a g0, g1 would no be shown on the screen. Only upper case G0,G1 is shown.
To replicate replace all G with g in a .nc file and load.
Checking the huge amount of sample g-code i gathered debugging user files, all I randomly checked have a capital G, so this might be not be a big issue. Just thought I would mention, because i also checked Camotics and bCNC and they display the cut, even with a lower case g.
I stumbled across this loading a file for a 'lift-desk' that I have created with FreeCAD ~ 2 years back, so perhaps v0.16?.
Checked recent FreeCAD files and they all have the capital G.
Kind regards, Gero
|
I thought I saw in the webcontrol code that it converts all the gcode to
capital letters. It doesn't save it, but it should not matter after the
conversion. What does it show when you view the lines of code in the code
viewer?
…On Thu, Aug 6, 2020, 11:11 AM David Lang ***@***.***> wrote:
I have seen other CNC machines that were case sensitive like this, so
while I
agree it would be good to make sure we aren't, it's not uncommon to be.
David Lang
On Thu, 6 Aug 2020, Gero wrote:
> Getting Webcontrol to run on my Ubuntu (fake servo to play, research and
understand, I noticed a g0, g1 would no be shown on the screen. Only upper
case G0,G1 is shown.
> To replicate replace all G with g in a .nc file and load.
> Checking the huge amount of sample g-code i gathered debugging user
files, all I randomly checked have a capital G, so this might be not be a
big issue. Just thought I would mention, because i also checked Camotics
and bCNC and they display the cut, even with a lower case g.
> I stumbled across this loading a file for a 'lift-desk' that I have
created with FreeCAD ~ 2 years back, so perhaps v0.16?.
> Checked recent FreeCAD files and they all have the capital G.
>
> Kind regards, Gero
>
>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#177 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOGADDZCTYRJO33DA3WBIVDR7LI4ZANCNFSM4PWVYKLA>
.
|
It shows all lines of the g-code and it also runs it. It is just not displaying the part on the screen. Totally white screen with the sled moving. |
Are they upper case in the viewer?
…On Thu, Aug 6, 2020, 11:53 AM Gero ***@***.***> wrote:
It shows all lines of the g-code and it also runs it. It is just not
displaying on the screen.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#177 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOGADD6DOCUZL7USJO6G4WTR7LNZBANCNFSM4PWVYKLA>
.
|
No, lower case. Accidental closed this... |
Reopened... Sorry |
I'll look into it later today.
…On Thu, Aug 6, 2020, 12:01 PM Gero ***@***.***> wrote:
Reopened... Sorry
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#177 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOGADD2Q6AO3ADHBFTW4JHDR7LOWNANCNFSM4PWVYKLA>
.
|
Webcontrol, single folder Version v0.94, Holey Firmware 51.27, Ubuntu 18.04.4 LTS bionic, Fake-Server mode. |
Webcontrol evolves over time and some functions get reorganized. I'm sure this goes back to the change to not modify the gcode file itself. If someone can try, add an .upper() call to gcodeFile.py around line 619..
|
I was looking at gcodefile.py and thinking line 253 and others like it
could be
if (command == "G00") or (command == "g00")
But converting to upper case earlier makes more sense and would work the
same.
…On Thu, Aug 6, 2020, 12:29 PM madgrizzle ***@***.***> wrote:
Webcontrol evolves over time and some functions get reorganized. I'm sure
this goes back to the change to not modify the gcode file itself. If
someone can try, add an .upper() call to gcodeFile.py around line 619..
fullString = (fullString.upper()+" ")
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#177 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOGADDYH6QFBLOG3V6S3XUTR7LR7FANCNFSM4PWVYKLA>
.
|
I did a locate to find the file, but it was found in a folder from Dec 2018. What did I do wrong? whoareyou4@dexter:~/Maslow/webcontrol/single_directory$ locate gcodeFile.py |
I'm referencing the gcodeFile.py file that's in the master branch on this repo. |
This uses the code fix Madgrizzle suggested. I tested it and also removed a file that got added a couple months ago as well. |
Getting Webcontrol to run on my Ubuntu (fake servo to play, research and understand, I noticed a g0, g1 would no be shown on the screen. Only upper case G0,G1 is shown.
To replicate replace all G with g in a .nc file and load.
Checking the huge amount of sample g-code i gathered debugging user files, all I randomly checked have a capital G, so this might be not be a big issue. Just thought I would mention, because i also checked Camotics and bCNC and they display the cut, even with a lower case g.
I stumbled across this loading a file for a 'lift-desk' that I have created with FreeCAD ~ 2 years back, so perhaps v0.16?.
Checked recent FreeCAD files and they all have the capital G.
Kind regards, Gero
The text was updated successfully, but these errors were encountered: