Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower case G-commands not visualized on screen, the g-code is loaded and runs #177

Closed
GeroBH opened this issue Aug 6, 2020 · 14 comments
Closed

Comments

@GeroBH
Copy link

GeroBH commented Aug 6, 2020

Getting Webcontrol to run on my Ubuntu (fake servo to play, research and understand, I noticed a g0, g1 would no be shown on the screen. Only upper case G0,G1 is shown.
To replicate replace all G with g in a .nc file and load.
Checking the huge amount of sample g-code i gathered debugging user files, all I randomly checked have a capital G, so this might be not be a big issue. Just thought I would mention, because i also checked Camotics and bCNC and they display the cut, even with a lower case g.
I stumbled across this loading a file for a 'lift-desk' that I have created with FreeCAD ~ 2 years back, so perhaps v0.16?.
Checked recent FreeCAD files and they all have the capital G.

Kind regards, Gero

@GeroBH GeroBH changed the title Lower case G-commands not visualized on screnn, the g-code is loaded and runs Lower case G-commands not visualized on screen, the g-code is loaded and runs Aug 6, 2020
@davidelang
Copy link

davidelang commented Aug 6, 2020 via email

@Orob-Maslow
Copy link
Contributor

Orob-Maslow commented Aug 6, 2020 via email

@GeroBH
Copy link
Author

GeroBH commented Aug 6, 2020

It shows all lines of the g-code and it also runs it. It is just not displaying the part on the screen. Totally white screen with the sled moving.

@Orob-Maslow
Copy link
Contributor

Orob-Maslow commented Aug 6, 2020 via email

@GeroBH GeroBH closed this as completed Aug 6, 2020
@GeroBH
Copy link
Author

GeroBH commented Aug 6, 2020

No, lower case. Accidental closed this...

@GeroBH
Copy link
Author

GeroBH commented Aug 6, 2020

image

@GeroBH GeroBH reopened this Aug 6, 2020
@GeroBH
Copy link
Author

GeroBH commented Aug 6, 2020

Reopened... Sorry

@Orob-Maslow
Copy link
Contributor

Orob-Maslow commented Aug 6, 2020 via email

@GeroBH
Copy link
Author

GeroBH commented Aug 6, 2020

Webcontrol, single folder Version v0.94, Holey Firmware 51.27, Ubuntu 18.04.4 LTS bionic, Fake-Server mode.
Files to compare:

Maslow-logo-upper-and-lower.zip

@madgrizzle
Copy link
Collaborator

Webcontrol evolves over time and some functions get reorganized. I'm sure this goes back to the change to not modify the gcode file itself. If someone can try, add an .upper() call to gcodeFile.py around line 619..

fullString = (fullString.upper()+" ")

@Orob-Maslow
Copy link
Contributor

Orob-Maslow commented Aug 6, 2020 via email

@GeroBH
Copy link
Author

GeroBH commented Aug 6, 2020

gcodeFile.py

I did a locate to find the file, but it was found in a folder from Dec 2018. What did I do wrong?

whoareyou4@dexter:~/Maslow/webcontrol/single_directory$ locate gcodeFile.py
/home/whoareyou4/Maslow/fw-test/WebControl-master/File/gcodeFile.py

@madgrizzle
Copy link
Collaborator

I did a locate to find the file, but it was found in a folder from Dec 2018. What did I do wrong?

I'm referencing the gcodeFile.py file that's in the master branch on this repo.

@Orob-Maslow
Copy link
Contributor

This uses the code fix Madgrizzle suggested. I tested it and also removed a file that got added a couple months ago as well.

#178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants