Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Walker class attribute escape #25

Merged

Conversation

codemascot
Copy link
Contributor

@codemascot codemascot commented Nov 8, 2017

As the data are coming from WordPress background, escaping attributes aren't that necessary. But I think best practice is where ever the data are coming form, that should be escaped and validated before storing in to database and presenting. So escaping the attributes are better here.

codemascot added 2 commits Nov 8, 2017
As the data are coming from WordPress background, escaping attributes aren't that necessary. But I think best practice what ever or where ever the data is coming form that should be escaped and validated before storing and presenting. So escaping the attributes are better here.
@jtsternberg jtsternberg merged commit 2627a04 into WebDevStudios:master Nov 16, 2017
@jtsternberg
Copy link
Contributor

jtsternberg commented Nov 16, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants