Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

Rename namespace so we can write custom sniffs #12

Merged
merged 10 commits into from
Jun 23, 2017
Merged

Rename namespace so we can write custom sniffs #12

merged 10 commits into from
Jun 23, 2017

Conversation

jrfoell
Copy link
Contributor

@jrfoell jrfoell commented Jun 22, 2017 •
edited by aubreypwd
Loading

Adds fix so that future sniffs can be written. Because of the - in -phpcs, this seems to screw up the namespacing work that PHPCS uses. Removing this -phpcs allows the parser to chain in properly.

Also fixes #3

@jrfoell jrfoell requested a review from aubreypwd June 22, 2017 15:32
@aubreypwd aubreypwd self-assigned this Jun 22, 2017
@aubreypwd aubreypwd requested a review from JayWood June 22, 2017 17:00
aubreypwd
aubreypwd approved these changes Jun 22, 2017
View reviewed changes
Copy link
Contributor

@aubreypwd aubreypwd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the change of my standard to WebDevStudios it still works.

@aubreypwd aubreypwd modified the milestone: 1.1 Jun 22, 2017
@aubreypwd
Copy link
Contributor

@JayWood You might also test this in storm, I tested Sublime and Atom and all still works with the configuration change.

@aubreypwd aubreypwd mentioned this pull request Jun 22, 2017
Closed
7 tasks
@aubreypwd aubreypwd changed the title Renamed directory to play nicely with class names for custom sniffs Rename namespace so we can write custom sniffs (release 1.0.1) Jun 23, 2017
@aubreypwd aubreypwd changed the title Rename namespace so we can write custom sniffs (release 1.0.1) Rename namespace so we can write custom sniffs (1.0.1) Jun 23, 2017
@aubreypwd aubreypwd added this to the 1.0.1 milestone Jun 23, 2017
@aubreypwd aubreypwd changed the title Rename namespace so we can write custom sniffs (1.0.1) Rename namespace so we can write custom sniffs Jun 23, 2017
@aubreypwd aubreypwd assigned kellenmace and unassigned JayWood Jun 23, 2017
@JayWood JayWood merged commit 8d74156 into master Jun 23, 2017
@JayWood JayWood deleted the feature/namespace-valid-dir branch June 23, 2017 20:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aubreypwd aubreypwd aubreypwd approved these changes

Assignees

@aubreypwd aubreypwd

Labels
Works in Atom Works in Sublime
Projects
None yet
Milestone
1.0.1
4 participants
@jrfoell @aubreypwd @JayWood @kellenmace