Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

Remove Squiz.Commenting.FunctionComme...intMissing #2

Merged
merged 1 commit into from
Apr 14, 2017

Conversation

aubreypwd
Copy link
Contributor

This removes Squiz.Commenting.FunctionComment.TypeHintMissing issue by removing Squiz.Commenting.FunctionComment all together until a new PR is made to fix it.

https://github.com/WebDevStudios/WDS-Coding-Standards/blob/master/WebDevStudios-phpcs/ruleset.xml#L23

This appears to be failing on Sublime:

As you can see, the Type hint "string" missing for $a in my status bar. Me and @JayWood both looked into this without any success, so I vote we remove it until a better ruleset can be figured out for anyone using this new standard.

We should note to check these new rulesets in Store, Sublime, Atom, eg. common editors before we add them in thefuture.

This removes Squiz.Commenting.FunctionComment.TypeHintMissing issue by removing Squiz.Commenting.FunctionComment all together until a new PR is made to fix it.
@aubreypwd aubreypwd requested a review from JayWood April 14, 2017 17:41
@aubreypwd aubreypwd self-assigned this Apr 14, 2017
@aubreypwd
Copy link
Contributor Author

I would also like to see us maybe adopt a release structure, vs just going off master, e.g. tag releases, etc somehow, so if this happens we can go back to e.g. 1.0 where it was stable.

Copy link
Contributor

@JayWood JayWood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working fine in storm, but for some reason sublime linter is ignoring the severity, it's safer to remove this for now until we re-test on all our editors.

@JayWood JayWood merged commit da27f4e into master Apr 14, 2017
@aubreypwd aubreypwd deleted the remove-typehint-error branch April 14, 2017 23:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants