This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
Remove Squiz.Commenting.FunctionComme...intMissing #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes Squiz.Commenting.FunctionComment.TypeHintMissing issue by removing Squiz.Commenting.FunctionComment all together until a new PR is made to fix it.
https://github.com/WebDevStudios/WDS-Coding-Standards/blob/master/WebDevStudios-phpcs/ruleset.xml#L23
This appears to be failing on Sublime:
As you can see, the
Type hint "string" missing for $a
in my status bar. Me and @JayWood both looked into this without any success, so I vote we remove it until a better ruleset can be figured out for anyone using this new standard.We should note to check these new rulesets in Store, Sublime, Atom, eg. common editors before we add them in thefuture.