Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

Feature/sass lint #26

Merged
merged 5 commits into from Dec 5, 2017
Merged

Feature/sass lint #26

merged 5 commits into from Dec 5, 2017

Conversation

gregrickaby
Copy link
Contributor

Closes #21

This brings in the latest .sass-lint.yml rules from wd_s.

@aubreypwd aubreypwd changed the base branch from master to release-1.1 August 24, 2017 17:45
@aubreypwd
Copy link
Contributor

@gregrickaby I assume this is working in your editor? What editor is that?

@aubreypwd
Copy link
Contributor

aubreypwd commented Sep 7, 2017 •
edited

  • We should also document it's use in editors as well

@gregrickaby
Copy link
Contributor Author

gregrickaby commented Sep 11, 2017 •
edited

@aubreypwd I've beefed up the SassLint documentation. View it here

@aubreypwd
Copy link
Contributor

Works in Atom:

The above is not in alpha order.

aubreypwd
aubreypwd approved these changes Sep 27, 2017
View reviewed changes
Copy link
Contributor

@aubreypwd aubreypwd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an FED, but this appears to work in Sublime and Atom so far. This has my blessing, but needs to get testing in storm (working on that right now, maybe Jay can do it)

@aubreypwd aubreypwd self-assigned this Sep 27, 2017
@aubreypwd aubreypwd added this to the 1.1 milestone Sep 27, 2017
@coreymcollins
Copy link
Contributor

Tested in Sublime as well and things appear to be working as expected!

@jomurgel
Copy link

Appears to be working in VSCode 👍

screenshot 2017-10-20 08 40 47
screenshot 2017-10-20 08 41 35

I upvote this bad boy.

@aubreypwd aubreypwd merged commit 75276aa into release-1.1 Dec 5, 2017
@aubreypwd aubreypwd deleted the feature/sass-lint branch December 5, 2017 21:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coreymcollins coreymcollins coreymcollins approved these changes

@aubreypwd aubreypwd aubreypwd approved these changes

Assignees

@aubreypwd aubreypwd

Labels
Needs Editor Testing Works in Atom Works in Sublime
Projects
None yet
Milestone
1.1
5 participants
@gregrickaby @aubreypwd @coreymcollins @jomurgel @jrfoell