Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

Warn when @author is missing. #51

Merged
merged 18 commits into from
Oct 19, 2018
Merged

Conversation

aubreypwd
Copy link
Contributor

@aubreypwd aubreypwd commented Oct 15, 2018

Resolves #5

TODO:

  • Add the rest of the cases we would enforce this on

What I've done is just required @author; due to the complexity of how we use this project to project I did not enforce a format. Also, just a warning and only enforced on functions and apply_filters/do_action.

@aubreypwd aubreypwd changed the title Feature/require @author Warn when @author is missing. Oct 15, 2018
@aubreypwd aubreypwd added this to the 1.2 milestone Oct 15, 2018
@aubreypwd aubreypwd self-assigned this Oct 15, 2018
@aubreypwd
Copy link
Contributor Author

aubreypwd commented Oct 16, 2018

  • Add ESLINT support

Though this will work on phpcs file.js, it won't work E.g. Sublime:

I imagine this is because sublime is running eslint and is overriding it?

@aubreypwd aubreypwd merged commit b62c452 into release-1.2 Oct 19, 2018
@aubreypwd aubreypwd deleted the feature/require-@author branch October 19, 2018 18:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant