eslint conflicting with prettier rule

[aubreypwd]

			// If we're clicking on this accordion...
			if ( content.previousElementSibling === targetParent ) {
				// If it's already opened, close it. Otherwise, open it!
				if ( 'false' === content.getAttribute( 'aria-hidden' ) ) {
					content.setAttribute( 'aria-hidden', 'true' );
					content.parentElement.classList.remove( 'open' );
				} else {
					content.setAttribute( 'aria-hidden', 'false' );
					content.parentElement.classList.add( 'open' );
				}
			} else {
				content.setAttribute( 'aria-hidden', 'true' );
				content.parentElement.classList.remove( 'open' );
			}
		} );

[aubreypwd]

I can confirm that this is not comming from eslint-config and we need to remove the prettier rule this conflicts with.

[aubreypwd]

I can confirm that prettier is removing this line on format, not sure why it's showing the lint in wd_s though...

[aubreypwd]

So after some googling, it turns out Prettier forces you to collapse empty lines, see:

• Suggestion: add option to retain blank lines prettier/prettier#554
• https://prettier.io/docs/en/rationale.html#empty-lines
• Prettier does not respect the "no-multiple-empty-lines" rule of eslint prettier/prettier-eslint#176
• Readability: Preserve existence of two or less blank lines between code chunks. prettier/prettier#1613
• Keep the empty line at the beginning of a function, if present. prettier/prettier#3501
• Readability: Preserve existence of two or less blank lines between code chunks. prettier/prettier#1613 (comment)

Now, the issue is that an empty line and a comment is seen a double 2 lines, which it collapses.

Prettier collapses multiple blank lines into a single blank line.

So what this means is that Prettier actually breaks one of our JavasScript rules which requires a blank line above comments, e.g.

...only when the comment is the first comment of the function, this works:

if ( true ) {
	let a = true;

	// The blank line above will not be collapsed by prettier.
	return true;
}

This does not, however, get fixed.

[aubreypwd]

This issue that arises, in how wd_s wants to fix everything on e.g. npm run lint is that Prettier breaks this rule, fixes it then eslint (maybe even via eslint --fix) will fix it back...

[TrejGun]

i have this issue too