Adds namespacing and makes function naming more consistent. #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batesweb
changed the title
jrfoell
reviewed
Oct 19, 2021
coreymcollins
added
the
documentation
aubreypwd
reviewed
Dec 30, 2021
There was a problem hiding this comment.
I can neither approve or reject this, I think either way we go Namespacing is super helpful here. I also like the nested namespacing e.g. for wd_s\functions and wd_s\template_tags vs. just piling them all in a single wd_s namespace.
Please see my advise though, as I think we can format this a little better...
|
@batesweb – it looks like this branch is a bit out of date now, and I'm not sure the full status of these updates. When you get a chance, can you review this branch, bring it up to date, and set it R4R if it's ready for final testing & review? Thanks! |
jrfoell
approved these changes
Jul 1, 2022
…use the custom function (get_post_content) to get content instead of wordpress default get_the_content
jrfoell
suggested changes
Jul 22, 2022
jrfoell
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #769
DESCRIPTION
Removes the function prefixes (
_s) and adds theWD_Snamespace throughout the theme.Updates function names to be more consistent. Functions that render markup start with
display_and functions that return data start withreturn_.SCREENSHOTS
Doesn't change anything visual in the theme. Just refactors the existing code.
OTHER
STEPS TO VERIFY
Test all theme functionality to make sure there are no namespacing issues.
DOCUMENTATION
Will this pull request require updating the wd_s wiki?