Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#162 Dependencies update #170

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

#162 Dependencies update #170

wants to merge 8 commits into from

Conversation

asharirfan
Copy link

Closes #162

Description

This PR updates project dev and prod dependencies present in package.json. It also fixes:

  • ESLint config according to latest update
  • Usage of @wordpress/element library
  • Some unknown react attribute errors
  • A couple of SASS errors
  • Style lint issues

Steps to verify the solution

How will a stakeholder test this? Please list the steps:

  1. Clone the plugin into a WordPress website.
  2. Try adding the blocks to a post in your website.
  3. Check for errors in the console.

@asharirfan asharirfan self-assigned this Jan 12, 2022
gregrickaby
gregrickaby suggested changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@gregrickaby gregrickaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asharirfan Can you fix up the merge conflict? Then I'll get this merged in. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregrickaby gregrickaby gregrickaby requested changes

At least 1 approving review is required to merge this pull request.

Assignees

@asharirfan asharirfan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update dependencies
2 participants
@asharirfan @gregrickaby