Hotfix/content blocks with sidebar #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregrickaby
approved these changes
May 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes WebDevStudios/wd_s#367
DESCRIPTION
@gregrickaby and I discovered that using full-width blocks would break the layout when used on a page/post with a sidebar. We logged it as a bug in wd_s, but in digging in it does appear that the issue lies in the plugin's base styles for layout. I'm not sure if these styles could necessarily be moved out of the plugin since they're not really opinionated and are just enough to get the layout working.
This looks for our
has-sidebarclass (used in wd_s) and doesn't apply full-width styles on blocks where that body class is found.SCREENSHOTS
OTHER
STEPS TO VERIFY
Add blocks to a post and give them a background image, color, or video. They should now stay within the content area rather than breaking like we were seeing in the wd_s issue noted above.