Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#137 Feature/template utilities #140

Merged
merged 10 commits into from
Mar 26, 2021

Conversation

richaber
Copy link
Contributor

Per #137

Start breaking some of the template responsibilities out into a Utilities class.
This is prep work for comparing customized template versions against versions that ship with the plugin.
This will be used for admin notices that warn users if their customized template versions are out of date.

  • Add Algolia_Template_Utils class
  • Rename TEMPLATES_DIR to PLUGIN_TEMPLATES_DIR
  • Require the Algolia_Template_Utils file
  • Deprecate Algolia_Template_Loader::locate_template and return Algolia_Template_Utils::locate_template
  • Return Algolia_Template_Utils::locate_template in Algolia_Template_Loader::load_autocomplete_template
  • Return Algolia_Template_Utils::locate_template in Algolia_Template_Loader::load_instantsearch_template
  • Clarify template locations in Algolia_Template_Loader::template_loader docblock
  • Deprecate algolia_templates_path filter
  • Deprecate Algolia_Plugin::get_templates_path method
  • Algolia_Template_Loader::load_autocomplete_template should require not return

Copy link
Contributor

@asharirfan asharirfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@richaber richaber merged commit 97dbbd6 into releases/1.8.0-dev Mar 26, 2021
@richaber richaber deleted the feature/template-utilities branch March 26, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants