Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esLint config setup , limited prettier to only src/public folder Issue#65 #68

Closed

Conversation

Zackaria-Slimane
Copy link

@Zackaria-Slimane Zackaria-Slimane commented Oct 3, 2021

Tried to limit the changes as best as i could on this one !
eslint and prettier configured, npm run lint script added and src - public files formatted

@Zackaria-Slimane
Copy link
Author

Review when you can please , @Binu42 😃

@Binu42
Copy link
Member

Binu42 commented Oct 7, 2021

Thanks, @Zackaria-Slimane , I'm not able to see changes for this we can create a pre-commit hook that will fix the linting of all the files before committing it.

@Zackaria-Slimane
Copy link
Author

Oh sorry, not native english speaker. I thought you sais that you would do that, i made that pre commit hook tested it and then took it off haha. Will add it asap

Copy link
Author

@Zackaria-Slimane Zackaria-Slimane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the pre commit hook

Copy link
Author

@Zackaria-Slimane Zackaria-Slimane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added all if what was asked, tested the pre commit hook

@@ -30,7 +30,8 @@
"eject": "react-scripts eject",
"netlify": "npm run build && netlify deploy --dir build && netlify deploy --prod --dir build",
"gitDeploy": "rm -rf ../'webdevscom deploy/*' && cp -r build/* ../webdevscom\\ deploy/ && cd ../webdevscom\\ deploy/ && git add . && git commit -m 'new build' && git push origin master && cd ../webdevscom",
"deploy": "npm run netlify && npm run gitDeploy"
"deploy": "npm run netlify && npm run gitDeploy",
"lint": "eslint ./src --fix "
Copy link
Member

@Binu42 Binu42 Oct 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where we are using this added lint cmd?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Npm run lint is used while you're working and wanna do it manually, else the command runs automatically when trying to push and it stops you if there's errors

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually inspite of stoping it from the push, I want linter to automatically fix the linting error and move ahead to further command.

@Binu42 Binu42 closed this Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants