discard onunload clean #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Thanks, looks good. I wonder whether a small section in the README would be warranted describing why developers should manually delete WebGL resources rather than letting the garbage collector do it. You could link to https://www.khronos.org/registry/webgl/specs/latest/1.0/#3 . We could add a name for that section, and add a rationale, too. Let me know. |
|
Good idea IMO. |
|
Thanks Patrick. Which part in particular? Do you want an update to the WebGL spec? |
|
Only if you think it is warranted. Just a short section in the README.md here as you suggested would be a nice start. |
|
OK. Please file an issue on KhronosGroup/WebGL if you want a "rationale" note added. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #87
glsl_flat_smooth_interpolators.htmlandtexture_vertex.htmlwill be fixed in gltf_loader branch, due to buffer change