-
Notifications
You must be signed in to change notification settings - Fork 1.3k
/
ChangeLog
17129 lines (11820 loc) · 623 KB
/
ChangeLog
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
2022-05-09 Ross Kirsling <ross.kirsling@sony.com>
Temporal and Date must reject expanded year -000000
https://bugs.webkit.org/show_bug.cgi?id=240263
Reviewed by Yusuke Suzuki.
* wtf/DateMath.cpp:
(WTF::parseES5DatePortion):
2022-05-09 Per Arne Vollan <pvollan@apple.com>
[macOS] HTTP traffic is not filtered in the parental controls filter
https://bugs.webkit.org/show_bug.cgi?id=240180
<rdar://problem/92875540>
Reviewed by Alexey Proskuryakov.
Add HAVE macro which tells us which OS versions are filtering HTTP traffic on behalf of WebKit.
* wtf/PlatformHave.h:
2022-05-08 Wenson Hsieh <wenson_hsieh@apple.com>
[iOS] Double tapping on YouTube video causes playback to pause instead of seek
https://bugs.webkit.org/show_bug.cgi?id=240222
rdar://92637636
Reviewed by Aditya Keerthi and Kate Cheney.
Add a new compile-time flag to guard the presence of `-[UITextInteractionAssistant contextMenuInteraction]`. See
WebKit/ChangeLog for more details.
* wtf/PlatformHave.h:
2022-05-09 Diego Pino Garcia <dpino@igalia.com>
Unreviewed, non-unified build fixes after r293562
* wtf/text/StringCommon.h:
2022-05-06 Megan Gardner <megan_gardner@apple.com>
Fix flakey test by using the old API on old systems.
https://bugs.webkit.org/show_bug.cgi?id=240195
Reviewed by Tim Horton.
* wtf/PlatformHave.h:
2022-05-06 Brent Fulgham <bfulgham@apple.com>
Remove unused ApplePayRemoteUIEnabled preference
https://bugs.webkit.org/show_bug.cgi?id=240177
Reviewed by Devin Rousso.
Remove the internal WKPreference for ApplePayRemoteUIEnabled now that
we always use the high-security remote ApplePay UI.
* Scripts/Preferences/WebPreferencesInternal.yaml:
2022-05-06 Brent Fulgham <bfulgham@apple.com>
Remove abandoned WKPreference for SelectionPaintingWithoutSelectionGaps
https://bugs.webkit.org/show_bug.cgi?id=240129
Reviewed by Alan Bujtas.
Remove the abandoned WKPreference 'SelectionPaintingWithoutSelectionGaps', which was added to support
the EFL port. As the EFL port is no longer buildable, and this code is never used outside of EFL, we
should remove this dead code.
* Scripts/Preferences/WebPreferences.yaml:
2022-05-06 Brent Fulgham <bfulgham@apple.com>
Remove internal WKPreference for non-iTunesAVOutput now that all platform support it
https://bugs.webkit.org/show_bug.cgi?id=240141
Reviewed by Eric Carlson.
WebKit on macOS has used a different AV Output target than IOS_FAMILY targets because those platforms lacked
the AVOutput option. Now that all platforms share this target, we can consolidate on the correct endpoint and
remove this preference code.
* Scripts/Preferences/WebPreferencesInternal.yaml:
2022-05-06 Brent Fulgham <bfulgham@apple.com>
Remove the viewportFitEnabled WKPreference now that it is always on
https://bugs.webkit.org/show_bug.cgi?id=240147
Reviewed by Tim Horton.
Remove the WKPreference 'ViewportFitEnabled' now that it is always enabled on all platforms, and
we do not wish to turn it off in testing or in other debugging circumstances.
* Scripts/Preferences/WebPreferences.yaml:
2022-05-05 Chris Dumez <cdumez@apple.com>
Identifier::string() should return an AtomString
https://bugs.webkit.org/show_bug.cgi?id=240122
Reviewed by Yusuke Suzuki.
* wtf/PrintStream.cpp:
(WTF::printInternal):
* wtf/PrintStream.h:
2022-05-05 Brent Fulgham <bfulgham@apple.com>
Remove abandoned WKPreference for AlwaysUseAcceleratedOverflowScroll
https://bugs.webkit.org/show_bug.cgi?id=240130
Reviewed by Simon Fraser.
The preference 'AlwaysUseAcceleratedOverflowScroll' and related code are no longer used. We should remove this dead code.
* Scripts/Preferences/WebPreferences.yaml:
2022-05-05 Manuel Rego Casasnovas <rego@igalia.com>
ARIA reflection for Element attributes
https://bugs.webkit.org/show_bug.cgi?id=239852
Reviewed by Chris Dumez.
Add new runtime flag AriaReflectionForElementReferencesEnabled.
* Scripts/Preferences/WebPreferencesExperimental.yaml:
2022-05-05 Sihui Liu <sihui_liu@apple.com>
SuspendableWorkQueue::suspend should invoke callback immediately when queue is suspended
https://bugs.webkit.org/show_bug.cgi?id=240070
Reviewed by Chris Dumez.
With current implementation, if suspend() is called when queue is suspended, the completionHandler is not
invoked unitl the queue is resumed and suspended again. This might cause confusion for callers. To fix it,
now SuspendableWorkQueue will invoke callback immediately when queue is already suspended.
API test: WTF_SuspendableWorkQueue.SuspendTwice
* wtf/SuspendableWorkQueue.cpp:
(WTF::SuspendableWorkQueue::suspend):
(WTF::SuspendableWorkQueue::resume):
(WTF::SuspendableWorkQueue::dispatchSync):
(WTF::SuspendableWorkQueue::suspendIfNeeded):
* wtf/SuspendableWorkQueue.h:
2022-05-04 Kimmo Kinnunen <kkinnunen@apple.com>
SharedMemory::systemPageSize is redundant function
https://bugs.webkit.org/show_bug.cgi?id=240057
Reviewed by Antti Koivisto.
* wtf/PageBlock.cpp:
(WTF::systemPageSize):
Remove pointless static variable from OS(WINDOWS) variant.
* wtf/linux/CurrentProcessMemoryStatus.cpp:
(WTF::currentProcessMemoryStatus):
Remove another redundant implementation.
2022-05-04 Brent Fulgham <bfulgham@apple.com>
Remove deprecated 'JavaEnabled' feature flag and related code
https://bugs.webkit.org/show_bug.cgi?id=240044
Reviewed by Darin Adler.
We removed support for Java Plug-Ins in macOS 10.15, but never removed the preference. To reduce code complexity
and build times we should remove this unused preference, leaving non-functional stubs to avoid breaking binaries
that expect to call their accessor methods.
* Scripts/Preferences/WebPreferences.yaml:
2022-05-04 Joonghun Park <jh718.park@samsung.com>
Unreviewed. Remove the build warning below since r293729.
warning: redundant move in return statement [-Wredundant-move]
* wtf/DateMath.cpp:
(WTF::validateTimeZone):
2022-05-03 Yusuke Suzuki <ysuzuki@apple.com>
[WTF] Initialize emptyString and nullString data at compile time
https://bugs.webkit.org/show_bug.cgi?id=240054
Reviewed by Mark Lam.
As we did for AtomString in r293757, we can initialize emptyString() and nullString()
data at compile time. This patch does that for WTF::String.
* wtf/text/WTFString.cpp:
(WTF::emptyString): Deleted.
(WTF::nullString): Deleted.
* wtf/text/WTFString.h:
(WTF::StaticString::StaticString):
(WTF::nullString):
(WTF::emptyString):
2022-05-03 Yusuke Suzuki <ysuzuki@apple.com>
[JSC] Initialize empty and null AtomString at compile time
https://bugs.webkit.org/show_bug.cgi?id=240031
Reviewed by Mark Lam.
Because they are initialized from static data, we can just initialize them
at compile time, and we do not need to have `AtomString::init`.
* wtf/Threading.cpp:
(WTF::initialize):
* wtf/text/AtomString.cpp:
(WTF::AtomString::init): Deleted.
* wtf/text/AtomString.h:
(WTF::StaticAtomString::StaticAtomString):
(WTF::nullAtom):
(WTF::emptyAtom):
2022-05-03 Chris Dumez <cdumez@apple.com>
REGRESSION (r293703): 358 JSC tests failing
https://bugs.webkit.org/show_bug.cgi?id=240023
<rdar://problem/92676663>
Reviewed by Yusuke Suzuki.
Make sure WTF::initialize() calls AtomString::init() given that JSC now relies on
emptyAtom().
* wtf/Threading.cpp:
(WTF::initialize):
* wtf/text/AtomString.cpp:
(WTF::AtomString::init):
2022-05-03 Philippe Normand <pnormand@igalia.com> and Pavel Feldman <pavel.feldman@gmail.com> and Yury Semikhatsky <yurys@chromium.org>
[WK2] Add API to allow embedder to set a timezone override
https://bugs.webkit.org/show_bug.cgi?id=213884
Reviewed by Yusuke Suzuki.
* wtf/DateMath.cpp: New APIs to control and query the timezone override.
(WTF::innerTimeZoneOverride): Static storage of the override informations.
(WTF::WTF_REQUIRES_LOCK):
(WTF::validateTimeZone): New function allowing to check if a timezone identifier is valid according to ICU's database and covert it
to UChar buffer suitable for passing to ucal.
(WTF::isTimeZoneValid):
(WTF::setTimeZoneOverride): New API to set the timezone override, this is meant to be
used on newly created WebProcesses. In addition to providing alternative name for the code
that calls into ICU library, on POSIX systems writes new timezone to "TZ" environement
variable to adjust result of strftime (called in formatDateTime).
(WTF::getTimeZoneOverride): Query the timezone override.
* wtf/DateMath.h:
2022-05-02 Justin Michaud <justin_michaud@apple.com>
Add option to JSC shell to wait for a USR2 signal before exiting to aid in collection of vmmaps
https://bugs.webkit.org/show_bug.cgi?id=239919
Reviewed by Yusuke Suzuki.
* wtf/threads/Signals.h:
(WTF::toSystemSignal):
2022-05-02 Eric Carlson <eric.carlson@apple.com>
[Cocoa] Allow more mime types in captive portal mode
https://bugs.webkit.org/show_bug.cgi?id=239859
rdar://91830683
Reviewed by Brent Fulgham.
* Scripts/Preferences/WebPreferences.yaml:
2022-04-29 Chris Dumez <cdumez@apple.com>
Unreviewed, reverting r293621.
Reverting patch while we fix internal EWS issues, will reland
after
Reverted changeset:
https://commits.webkit.org/r293621
2022-04-29 Philippe Normand <philn@igalia.com>
REGRESSION(r293608): [GTK][WPE] Broke clang builds
https://bugs.webkit.org/show_bug.cgi?id=239899
Reviewed by Michael Catanzaro.
* wtf/StdLibExtras.h: Restrict std::remove_cvref hacks to GCC.
2022-04-29 Diego Pino Garcia <dpino@igalia.com>
[GCC] std::remove_cvref is undefined in GCC8.4
https://bugs.webkit.org/show_bug.cgi?id=239881
Reviewed by Žan Doberšek.
r293505 changed the guard that added std::remove_cvref if not defined
by GCC, checking __cplusplus <= 201703L.
However in Ubuntu GCC8.4 this flag's value is 201709L. Thus, the
evaluation of this flag cannot reliably determine whether the compiler
has to define std::remove_cvref or not.
Instead of relying on a predefined compiler flag, what the patch does is
to attempt to compile a small snippet of code to check whether std::remove_cvref
is supported by the compiler. If successful, the flag 'HAVE_STD_REMOVE_CVREF' is defined.
* wtf/StdLibExtras.h: Define std::remove_cvref if not defined by GCC.
2022-04-27 Yusuke Suzuki <ysuzuki@apple.com>
[JSC] Make DFG::OSRExit data unlinked
https://bugs.webkit.org/show_bug.cgi?id=239828
Reviewed by Saam Barati.
* wtf/FixedVector.h:
2022-04-28 Brent Fulgham <bfulgham@apple.com>
Remove the AVFoundationNSURLSessionEnabled preference
https://bugs.webkit.org/show_bug.cgi?id=239632
Reviewed by Eric Carlson.
All supported operating systems have supported AVFoundationNSURLSession
for several years. Since we expect AVFoundation to always use WebKit
for network loading (and indeed, expect improper behavior if we do not)
we should remove this toggle to simplify the code and reduce the chance
for users to mistakenly activate it.
* Scripts/Preferences/WebPreferences.yaml:
2022-04-28 Yusuke Suzuki <ysuzuki@apple.com>
Support C files in Unified Builds
https://bugs.webkit.org/show_bug.cgi?id=239873
Reviewed by Mark Lam.
Fix a bug that we always generate empty UnifiedSource-1.xxx.
It also fixes a bug that this script cannot handle 0 max bundle count.
* Scripts/generate-unified-source-bundles.rb:
2022-04-28 Wenson Hsieh <wenson_hsieh@apple.com>
REGRESSION (DOM GPUP): Rich HTML emails on watchOS no longer show up
https://bugs.webkit.org/show_bug.cgi?id=239870
rdar://91311606
Reviewed by Tim Horton.
Temporarily turn GPU process for DOM off by default on watchOS.
* Scripts/Preferences/WebPreferencesExperimental.yaml:
2022-04-28 Per Arne Vollan <pvollan@apple.com>
Dynamically switch message filter
https://bugs.webkit.org/show_bug.cgi?id=238577
<rdar://69263324>
Reviewed by Geoffrey Garen.
Add SPI to set sandbox state variable.
* wtf/spi/darwin/SandboxSPI.h:
2022-04-28 Yusuke Suzuki <ysuzuki@apple.com>
[WTF] Use quadratic-probing instead of double-hashing
https://bugs.webkit.org/show_bug.cgi?id=239813
Reviewed by Geoffrey Garen.
If table size is always power-of-two, we can safely use quadratic-probing[1] even if the load exceeds 50%.
Quadratic-probing and double-hashing have different tradeoff between clustering possibility and CPU cache
friendliness. Double-hashing can avoid clustering more, but it is not CPU cache friendly. Quadratic-probing
can cause clustering more but better for CPU cache. And while linear-probing caused a lot of trouble and not
practical, quadratic-probing with 75% load factor is practical configuration which is used in production-ready
hashtables e.g. Google's sparsetable / densetable[2].
This patch replaces WTF::HashTable's probing algorithm from double-hashing to quadratic-probing to make it more
cache friendly while keeping reasonable clustering characteristics (compared to linear-probing etc.). Due to
this cache friendliness, we get large performance improvements.
1. 0.52% improvement in Speedometer2 with 95% probability.
2. 0.72% improvement in JetStream2 with 98% probability.
[1]: https://fgiesen.wordpress.com/2015/02/22/triangular-numbers-mod-2n/
[2]: http://goog-sparsehash.sourceforge.net/doc/implementation.html
* wtf/HashTable.h:
(WTF::KeyTraits>::inlineLookup):
(WTF::KeyTraits>::lookupForWriting):
(WTF::KeyTraits>::fullLookupForWriting):
(WTF::KeyTraits>::addUniqueForInitialization):
(WTF::KeyTraits>::add):
(WTF::doubleHash): Deleted.
2022-04-28 Per Arne Vollan <pvollan@apple.com>
[iOS] Enable IOKit blocking in GPUP by default
https://bugs.webkit.org/show_bug.cgi?id=239615
Reviewed by Darin Adler.
* Scripts/Preferences/WebPreferencesInternal.yaml:
2022-04-26 Justin Michaud <justin_michaud@apple.com>
[PGO] Allow collecting other kinds of pgo profiles
https://bugs.webkit.org/show_bug.cgi?id=239776
Reviewed by Saam Barati.
Update the way we collect PGO profiles to use LLVM's file handling, because
it really seems to care about that. This allowws us to try out other kinds
of profile generation, like the IR-based -fcs-profile-generate.
* wtf/GenerateProfiles.h:
(WTF::registerProfileGenerationCallback):
2022-04-27 Diego Pino Garcia <dpino@igalia.com>
[GCC] GCC9.3 defines 'remove_cvref_t' but not '__cpp_lib_remove_cvref'
https://bugs.webkit.org/show_bug.cgi?id=239805
Reviewed by Žan Doberšek.
GCC9.3 defines 'remove_cvref_t' but not '__cpp_lib_remove_cvref'. The
latter was introduced in GCC9.4:
https://github.com/gcc-mirror/gcc/blob/releases/gcc-9.4.0/libstdc%2B%2B-v3/include/std/type_traits#L3024
The flag '__cpp_lib_remove_cvref' is used to check whether 'remove_cvref_t'
is defined, but it's not posible to rely on it for GCC9.3 as explained on the
paragraph above.
Instead we check whether __cplusplus is <= 201703L since the GCC commit
that defined 'remove_cvref_t' does it if __cplusplus > 201703L. See:
https://github.com/gcc-mirror/gcc/commit/6791489ee5214b0181aa22adc250cbbde1897a5c
* wtf/StdLibExtras.h:
2022-04-26 Manuel Rego Casasnovas <rego@igalia.com>
Remove AriaReflectionEnabled runtime flag
https://bugs.webkit.org/show_bug.cgi?id=239532
Reviewed by Chris Fleizach.
* Scripts/Preferences/WebPreferencesInternal.yaml:
2022-04-26 Kate Cheney <katherine_cheney@apple.com>
Remove WebArchiveDebugMode
https://bugs.webkit.org/show_bug.cgi?id=239738
<rdar://problem/88406961>
Reviewed by Tim Horton.
* Scripts/Preferences/WebPreferences.yaml:
2022-04-23 Wenson Hsieh <wenson_hsieh@apple.com>
Remove the `PreferInlineTextSelectionInImages` internal feature flag
https://bugs.webkit.org/show_bug.cgi?id=234849
Reviewed by Sam Weinig.
See WebKit/ChangeLog for more details.
* Scripts/Preferences/WebPreferencesInternal.yaml:
2022-04-22 Chris Dumez <cdumez@apple.com>
Move global AtomStrings to a common header to promote reuse
https://bugs.webkit.org/show_bug.cgi?id=239585
Reviewed by Geoff Garen and Darin Adler.
* wtf/text/AtomString.cpp:
(WTF::AtomString::init):
* wtf/text/AtomString.h:
(WTF::xmlnsAtom):
(WTF::trueAtom): Deleted.
(WTF::falseAtom): Deleted.
2022-04-22 Diego Pino Garcia <dpino@igalia.com>
Unreviewed, non-unified build fixes after r293203
* wtf/RobinHoodHashTable.h:
2022-04-22 Alan Bujtas <zalan@apple.com>
[LFC][Integration] Add FlexFormattingContextIntegrationEnabled setting
https://bugs.webkit.org/show_bug.cgi?id=239654
Reviewed by Antti Koivisto.
* Scripts/Preferences/WebPreferencesInternal.yaml:
2022-04-20 Yusuke Suzuki <ysuzuki@apple.com>
[WTF] Add string concatenate adapter for UUID
https://bugs.webkit.org/show_bug.cgi?id=239590
Reviewed by Chris Dumez and Darin Adler.
This patch adds string concatenate adapter for UUID.
UUID's stringifier consists of multiple string concatenate adapters.
This patch adds WTF::handleWithAdapters so that we can define adapters
once, and we can semi-automatically define length() and writeTo method for UUID.
And we use UUID + makeString instead of createVersion4UUIDString. This is more
efficient since we do not need to allocate string twice.
* wtf/URL.cpp:
(WTF::URL::fakeURLWithRelativePart):
* wtf/UUID.cpp:
(WTF::UUID::generateWeakRandomUUIDVersion4):
(WTF::UUID::toString const):
(WTF::createVersion4UUIDString):
(WTF::generateWeakRandomUUIDVersion4): Deleted.
(WTF::createVersion4UUIDStringWeak): Deleted.
* wtf/UUID.h:
(WTF::UUID::createVersion4Weak):
(WTF::UUID::data const):
(WTF::StringTypeAdapter<UUID>::StringTypeAdapter):
(WTF::StringTypeAdapter<UUID>::handle const):
(WTF::StringTypeAdapter<UUID>::length const):
(WTF::StringTypeAdapter<UUID>::is8Bit const):
(WTF::StringTypeAdapter<UUID>::writeTo const):
* wtf/text/StringConcatenate.h:
(WTF::handleWithAdapters):
2022-04-21 Brent Fulgham <bfulgham@apple.com>
Remove XSS Auditor: Part 4 (Settings)
https://bugs.webkit.org/show_bug.cgi?id=239628
Reviewed by Alex Christensen.
This change is a follow-up to Bug 230661 that removes the unused
WebPreferences.yaml content.
* Scripts/Preferences/WebPreferences.yaml:
2022-04-21 Chris Dumez <cdumez@apple.com>
Adopt RobinHoodHashMap / RobinHoodHashSet more broadly in WebCore
https://bugs.webkit.org/show_bug.cgi?id=239576
Reviewed by Yusuke Suzuki.
Allow using RobinHoodHashMap / RobinHoodHashSet with URL keys since a URL wraps a String
and uses its internal String's cached hash as hash.
* wtf/URLHash.h:
2022-04-21 Diego Pino Garcia <dpino@igalia.com>
REGRESSION(r292863): std::remove_cvref_t not defined in GCC9<
https://bugs.webkit.org/show_bug.cgi?id=239482
Reviewed by Žan Doberšek.
std::remove_cvref_t is only available since GCC9 onwards:
https://en.cppreference.com/w/cpp/compiler_support/20
* wtf/StdLibExtras.h: add remove_cvref_t to std namespace if not defined.
2022-04-20 Chris Dumez <cdumez@apple.com>
Move true / false AtomStrings to a central location and reuse them
https://bugs.webkit.org/show_bug.cgi?id=239530
Reviewed by Sam Weinig.
* wtf/text/AtomString.cpp:
(WTF::AtomString::init):
* wtf/text/AtomString.h:
(WTF::trueAtom):
(WTF::falseAtom):
2022-04-20 Alan Bujtas <zalan@apple.com>
[IFC][Integration] Do not call WebPreferences::simpleLineLayoutEnabled in canUseForLineLayoutWithReason
https://bugs.webkit.org/show_bug.cgi?id=239540
Reviewed by Antti Koivisto.
* Scripts/Preferences/WebPreferencesInternal.yaml:
2022-04-20 Cathie Chen <cathiechen@igalia.com>
Parsing of contain-intrinsic-size and adding a runtime flag for it
https://bugs.webkit.org/show_bug.cgi?id=238181
Reviewed by Simon Fraser.
* Scripts/Preferences/WebPreferencesExperimental.yaml:
2022-04-19 Chris Dumez <cdumez@apple.com>
Use more r-value references for Text / CharacterData classes
https://bugs.webkit.org/show_bug.cgi?id=239481
Reviewed by Sam Weinig.
Add a function to AtomString to release its String. This is convenient when you have an AtomString
and need a String&&.
* wtf/text/AtomString.h:
2022-04-19 Chris Dumez <cdumez@apple.com>
Replace String::replaceWithLiteral() with a String::replace() overload that takes in an ASCIILiteral
https://bugs.webkit.org/show_bug.cgi?id=239500
Reviewed by Darin Adler.
Replace String::replaceWithLiteral() with a String::replace() overload that takes in an ASCIILiteral.
replaceWithLiteral() was encouraging people not to use ASCIILiteral and the ""_s suffix and calling
replace() with an ASCIILiteral would result in less efficient code, which goes against the idea of
ASCIILiteral.
To address this, String::replaceWithLiteral() is removed. Now, callers can call String::replace()
with an ASCIILiteral instead and it will result in code that is as efficient. I have verified that
this change is perf-neutral on Speedometer on both Apple Silicon and Intel.
* wtf/text/WTFString.h:
(WTF::String::replace):
(WTF::String::replaceWithLiteral): Deleted.
2022-04-19 Chris Dumez <cdumez@apple.com>
Introduce makeAtomString()
https://bugs.webkit.org/show_bug.cgi?id=239464
Reviewed by Sam Weinig.
Introduce makeAtomString() which is an optimized version of makeString() when the caller knows it wants an
AtomString. It may avoid a StringImpl allocation when the string is already in the AtomStringTable.
* wtf/text/StringConcatenate.h:
(WTF::tryMakeAtomStringFromAdapters):
(WTF::tryMakeAtomString):
(WTF::makeAtomString):
2022-04-18 Elliott Williams <emw@apple.com>
[XCBuild] Use XCBuild for all command-line and project builds
https://bugs.webkit.org/show_bug.cgi?id=238916
Reviewed by Alexey Proskuryakov.
* WTF.xcodeproj/project.pbxproj:
2022-04-17 Chris Dumez <cdumez@apple.com>
Leverage StringView in more places
https://bugs.webkit.org/show_bug.cgi?id=239426
Reviewed by Sam Weinig.
Leverage StringView in more places, to reduce the number of String allocations.
* wtf/text/StringImpl.cpp:
* wtf/text/StringImpl.h:
(WTF::isNotSpaceOrNewline):
* wtf/text/WTFString.h:
2022-04-16 Chris Dumez <cdumez@apple.com>
Drop String::truncate() and use String::left() instead
https://bugs.webkit.org/show_bug.cgi?id=239412
Reviewed by Darin Adler.
String::truncate() and String::left() have identical behavior. The only difference is that truncate()
modifies the String in place (which is a bit confusing), while left() returns a new String, without
modifying the original. To simplify our API, I am dropping String::truncate().
* wtf/text/WTFString.cpp:
(WTF::String::truncate): Deleted.
* wtf/text/WTFString.h:
* wtf/unix/LanguageUnix.cpp:
(WTF::platformLanguage):
* wtf/win/LanguageWin.cpp:
(WTF::localeInfo):
2022-04-16 Chris Dumez <cdumez@apple.com>
Replace complex String::insert() with a simplified makeStringByInserting() free function
https://bugs.webkit.org/show_bug.cgi?id=239370
Reviewed by Darin Adler.
* wtf/text/WTFString.cpp:
(WTF::makeStringByInserting):
(WTF::String::insert): Deleted.
(WTF::String::append): Deleted.
* wtf/text/WTFString.h:
2022-04-15 Myles C. Maxfield <mmaxfield@apple.com>
[WebGPU] Implement hardware limits
https://bugs.webkit.org/show_bug.cgi?id=239377
Reviewed by Darin Adler.
Add missing #include.
* wtf/PageBlock.h:
2022-04-15 Michael Catanzaro <mcatanzaro@redhat.com>
IGNORE_WARNINGS_BEGIN should not warn about unrecognized warnings
https://bugs.webkit.org/show_bug.cgi?id=239344
Reviewed by Darin Adler.
If the compiler does not support __has_warning(), then let's also
suppress -Wpragmas to avoid warnings about unrecognized warnings.
Let's make a couple drive-by cleanups as well. Notably,
IGNORE_WARNINGS_BEGIN_IMPL_ is unused and can be removed.
* wtf/Compiler.h:
2022-04-15 Zan Dobersek <zdobersek@igalia.com>
[GTK][WPE] Remove exclusive build guards around GPU process preferences, code
https://bugs.webkit.org/show_bug.cgi?id=239331
Reviewed by Philippe Normand.
* Scripts/Preferences/WebPreferencesExperimental.yaml:
Make the UseGPUProcessForWebGLEnabled option also usable for the GTK and
WPE ports.
2022-04-14 J Pascoe <j_pascoe@apple.com>
[WebAuthn] Clean up WebAuthenticationModern and WebAuthnProcess
https://bugs.webkit.org/show_bug.cgi?id=239073
rdar://problem/91571030
Reviewed by Brent Fulgham.
* Scripts/Preferences/WebPreferencesExperimental.yaml:
2022-04-14 Chris Dumez <cdumez@apple.com>
Drop inefficient String::append() overloads
https://bugs.webkit.org/show_bug.cgi?id=239289
Reviewed by Sam Weinig.
* wtf/Assertions.cpp:
* wtf/text/StringBuilder.h:
(WTF::StringBuilder::append):
* wtf/text/WTFString.cpp:
(WTF::String::insert):
(WTF::String::append):
* wtf/text/WTFString.h:
2022-04-14 Justin Michaud <justin_michaud@apple.com>
[PGO] We should be able to build WebKit to collect PGO profiles easily
https://bugs.webkit.org/show_bug.cgi?id=238776
Reviewed by Wenson Hsieh.
Build WebKit as follows: make release WK_LTO_MODE=thin ENABLE_LLVM_PROFILE_GENERATION=ON
Then, follow the directions in the log output at runtime to collect your raw PGO profiles!
We add a new compile flag plus WTF::registerProfileGenerationCallback, allowing llvm profiles
to be collected by sending a notifyutil signal. The files are written to the temp directory,
and it seems like the sandbox permits this by default. You may need to disable the sandbox if
you encounter issues, either by editing the *.sb files or by using an inserted dylib to interpose
the sandbox initialization calls.
* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/GenerateProfiles.h: Added.
(WTF::registerProfileGenerationCallback):
* wtf/PlatformEnable.h:
2022-04-14 Zan Dobersek <zdobersek@igalia.com>
[WK2] Enable more efficient encoding of synchronous-message reply arguments
https://bugs.webkit.org/show_bug.cgi?id=238740
<rdar://problem/91567779>
Reviewed by Kimmo Kinnunen.
Add two helper types, OutType and InTypes, on both CompletionHandler
classes. OutType is an alias against the return type of the invokable
handler, InTypes is a tuple with types corresponding to the parameter
types of the invokable handler.
These are especially helpful in various templates dealing with the
CompletionHandler types.
* wtf/CompletionHandler.h:
(WTF::CompletionHandler):
(WTF::CompletionHandlerWithFinalizer):
2022-04-13 Chris Dumez <cdumez@apple.com>
Replace calls to substring(0, x) with the more concise left(x)
https://bugs.webkit.org/show_bug.cgi?id=239306
Reviewed by Darin Adler.
* wtf/URL.cpp:
(WTF::URL::protocol const):
(WTF::URL::protocolHostAndPort const):
(WTF::URL::setProtocol):
(WTF::URL::setHost):
(WTF::URL::setHostAndPort):
(WTF::URL::strippedForUseAsReferrer const):
* wtf/URLParser.cpp:
(WTF::URLParser::addNonSpecialDotSlash):
(WTF::URLParser::parseURLEncodedForm):
* wtf/UUID.cpp:
(WTF::UUID::parse):
* wtf/text/WTFString.cpp:
(WTF::String::insert):
* wtf/text/WTFString.h:
2022-04-13 Alex Christensen <achristensen@webkit.org>
Punycode encode U+15AF when not in context of other Canadian aboriginal code points
https://bugs.webkit.org/show_bug.cgi?id=239316
<rdar://91248059>
Reviewed by Darin Adler.
* wtf/URLHelpers.cpp:
(WTF::URLHelpers::isLookalikeCharacterOfScriptType<USCRIPT_CANADIAN_ABORIGINAL>):
(WTF::URLHelpers::isLookalikeCharacter):
2022-04-13 Chris Dumez <cdumez@apple.com>
Drop unused AtomString(const LChar*) constructor
https://bugs.webkit.org/show_bug.cgi?id=239274
Reviewed by Darin Adler.
* wtf/text/AtomString.h:
2022-04-13 Wenson Hsieh <wenson_hsieh@apple.com>
MSE video is not drawn onto canvas
https://bugs.webkit.org/show_bug.cgi?id=206812
rdar://31763425
Reviewed by Eric Carlson.
Enable MediaSource inline painting by default on all platforms where `AVSampleBufferVideoOutput` has been tuned
with a more aggressive pruning interval; this avoids significant increases in memory and power use when
utilizing the sample buffer to snapshot videos with MSE.
* Scripts/Preferences/WebPreferencesExperimental.yaml:
2022-04-13 Chris Dumez <cdumez@apple.com>
Replace AtomString(const char*) with AtomString::fromLatin1(const char*)
https://bugs.webkit.org/show_bug.cgi?id=239127
Reviewed by Darin Adler.
* wtf/text/AtomString.cpp:
(WTF::AtomString::init):
* wtf/text/AtomString.h:
(WTF::operator==):
(WTF::operator!=):
2022-04-12 Elliott Williams <emw@apple.com>
[Xcode] In open-source builds, disable bitcode in xcconfigs instead of build-webkit
https://bugs.webkit.org/show_bug.cgi?id=239262
Reviewed by Alexey Proskuryakov.
* Configurations/Base.xcconfig:
2022-04-12 Tim Horton <timothy_horton@apple.com>
Adopt "version set"-based linked-on-or-after checks instead of platform-specific ones
https://bugs.webkit.org/show_bug.cgi?id=239054
<rdar://problem/83436715>
Reviewed by Wenson Hsieh.
Switch to `dyld_program_sdk_at_least`, which correctly handles SDK
checks for binaries built for one SDK running on another platform
(e.g. iOS apps running on macOS).
Because `dyld_program_sdk_at_least` is based off more than a simple
integer comparison like our old SDK check, we move it into the
application process, and just transmit the computed behaviors to
subprocesses.
Remove functions that expose/transmit platform-specific SDK versions,
so that usage isn't accidentally reintroduced.
Re-frame the naming of our linked-on-or-after checks as being about
specific behaviors instead of SDK versions.
* wtf/Bitmap.h:
(WTF::WordType>::setAll):
Add `setAll`, which sets all the bits in the Bitmap, like FastBitVector has.
Expose the length of the data in bytes to make transmitting the Bitmap simple.
* wtf/cocoa/LanguageCocoa.mm:
(WTF::canMinimizeLanguages):
Adopt the new naming.
* wtf/spi/darwin/dyldSPI.h:
Because of the nature of dyld_build_version_t values, we can't forward
declare them. Thus, maintain a fallback to the legacy platform-specific
SDK checks for use when building against the internal SDK, or when
back-deploying to older SDKs that don't yet have values for newer version sets.
* wtf/cocoa/RuntimeApplicationChecksCocoa.cpp:
(disableAdditionalSDKAlignedBehaviors):
(WTF::computeSDKAlignedBehaviors):
(WTF::sdkAlignedBehaviorsValue):
(WTF::sdkAlignedBehaviors):
(WTF::setSDKAlignedBehaviors):
(WTF::enableAllSDKAlignedBehaviors):
(WTF::disableAllSDKAlignedBehaviors):
(WTF::linkedOnOrAfterSDKWithBehavior):
(WTF::applicationSDKVersionOverride): Deleted.
(WTF::setApplicationSDKVersion): Deleted.
(WTF::applicationSDKVersion): Deleted.
(WTF::linkedOnOrAfterOverrideValue): Deleted.
(WTF::setLinkedOnOrAfterOverride): Deleted.
(WTF::linkedOnOrAfterOverride): Deleted.
(WTF::linkedOnOrAfter): Deleted.
* wtf/cocoa/RuntimeApplicationChecksCocoa.h:
2022-04-12 Elliott Williams <emw@apple.com>
Reland "[XCBuild] Enable dependency validation by default"
https://bugs.webkit.org/show_bug.cgi?id=238901
<rdar://problem/91379968>
Reviewed by Alexey Proskuryakov.
* Configurations/DebugRelease.xcconfig: In open-source builds, disable
VALIDATE_DEPENDENCIES when there is no PRODUCT_TYPE (i.e. not building
a native target).
2022-04-12 Kimmo Kinnunen <kkinnunen@apple.com>
FunctionDispatcher should not be RefCounted
https://bugs.webkit.org/show_bug.cgi?id=231940
Reviewed by Chris Dumez.
Remove ThreadSafeRefCounted from FunctionDispatcher. There is nothing inherently
refcountable about FunctionDispatcher. It is better to put the refcount to the
abstraction that needs it.
This makes it possible to build FunctionDispatchers that are not refcounted. This
lets the reader infer more about the API when such a dispatcher is passed to a
function. The reader understands that the passed dispatcher would not be kept alive.
* wtf/FunctionDispatcher.h:
* wtf/RunLoop.h:
Export ~RunLoop. For some reason this is a requirement on G++, MSVC based compilers (?).
This has most likely something to do with the multiple inheritance moving to RunLoop
from FunctionDispatcher. ~FunctionDispacher was exported before, and still is.
* wtf/WorkQueue.h:
2022-04-11 Don Olmstead <don.olmstead@sony.com>
Fix PlayStation build after r292696
https://bugs.webkit.org/show_bug.cgi?id=239098