Skip to content

Commit

Permalink
REGRESSION: 4 PiP API tests consistently failing on Big Sur EWS
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=247373
rdar://101873453

Unreviewed test gardening.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
(TestWebKitAPI::TEST): Disable test on Big Sur to speed up EWS.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
(TEST): Ditto.

Canonical link: https://commits.webkit.org/256245@main
  • Loading branch information
ryanhaddad committed Nov 2, 2022
1 parent 8d013e8 commit 01ba18b
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 1 deletion.
Expand Up @@ -95,8 +95,12 @@ - (void)_webViewDidExitFullscreen:(WKWebView *)webView
TestWebKitAPI::Util::run(&didExitPiP);
}


// FIXME: Re-enable this test for Big Sur once webkit.org/b/245241 is resolved
#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 120000)
TEST(ExitFullscreenOnEnterPiP, DISABLED_ElementFullscreen)
#else
TEST(ExitFullscreenOnEnterPiP, ElementFullscreen)
#endif
{
[[NSUserDefaults standardUserDefaults] registerDefaults:@{
@"WebCoreLogging": @"Fullscreen=debug",
Expand Down
Expand Up @@ -60,7 +60,12 @@ static void loadPictureInPicture(RetainPtr<TestWKWebView> webView)
} while (true);
}

// FIXME: Re-enable this test for Big Sur once webkit.org/b/245241 is resolved
#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 120000)
TEST(WKWebViewCloseAllMediaPresentations, DISABLED_PictureInPicture)
#else
TEST(WKWebViewCloseAllMediaPresentations, PictureInPicture)
#endif
{
if (!WebCore::supportsPictureInPicture())
return;
Expand All @@ -85,7 +90,12 @@ static void loadPictureInPicture(RetainPtr<TestWKWebView> webView)
EXPECT_TRUE([webView _allMediaPresentationsClosed]);
}

// FIXME: Re-enable this test for Big Sur once webkit.org/b/245241 is resolved
#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 120000)
TEST(WKWebViewCloseAllMediaPresentationsInternal, DISABLED_PictureInPicture)
#else
TEST(WKWebViewCloseAllMediaPresentationsInternal, PictureInPicture)
#endif
{
if (!WebCore::supportsPictureInPicture())
return;
Expand Down Expand Up @@ -177,7 +187,12 @@ static void loadPictureInPicture(RetainPtr<TestWKWebView> webView)
EXPECT_TRUE([webView _allMediaPresentationsClosed]);
}

// FIXME: Re-enable this test for Big Sur once webkit.org/b/245241 is resolved
#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 120000)
TEST(WKWebViewCloseAllMediaPresentations, DISABLED_MultipleSequentialCloseAllMediaPresentations)
#else
TEST(WKWebViewCloseAllMediaPresentations, MultipleSequentialCloseAllMediaPresentations)
#endif
{
if (!WebCore::supportsPictureInPicture())
return;
Expand Down

0 comments on commit 01ba18b

Please sign in to comment.