Skip to content

Commit

Permalink
Remove an unnecessary call to -[UIKeyboardImpl clearShiftState] after…
Browse files Browse the repository at this point in the history
… rdar://118307508

https://bugs.webkit.org/show_bug.cgi?id=265002
rdar://118543047

Reviewed by Richard Robinson and Megan Gardner.

Remove this call to `-[UIKeyboardImpl clearShiftState]`, which is no longer needed after the changes
in rdar://118307508.

* Source/WebKit/Platform/spi/ios/UIKitSPI.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _selectionChanged]):

Canonical link: https://commits.webkit.org/270911@main
  • Loading branch information
whsieh committed Nov 17, 2023
1 parent d08dfb4 commit 027711e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion Source/WebKit/Platform/spi/ios/UIKitSPI.h
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,6 @@ typedef struct CGSVGDocument *CGSVGDocumentRef;
- (BOOL)handleKeyInputMethodCommandForCurrentEvent;
- (void)addInputString:(NSString *)string withFlags:(NSUInteger)flags withInputManagerHint:(NSString *)hint;
- (BOOL)autocorrectSpellingEnabled;
- (void)clearShiftState;
- (void)deleteFromInputWithFlags:(NSUInteger)flags;
- (void)replaceText:(id)replacement;
@property (nonatomic, readwrite, retain) UIResponder <UIKeyInput> *delegate;
Expand Down
2 changes: 0 additions & 2 deletions Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
Original file line number Diff line number Diff line change
Expand Up @@ -8449,8 +8449,6 @@ - (void)_selectionChanged

if (_page->editorState().hasPostLayoutAndVisualData()) {
_lastInsertedCharacterToOverrideCharacterBeforeSelection = std::nullopt;
if (!_usingGestureForSelection && _focusedElementInformation.autocapitalizeType == WebCore::AutocapitalizeType::Words)
[UIKeyboardImpl.sharedInstance clearShiftState];

if (!_usingGestureForSelection && !_selectionChangeNestingLevel && _page->editorState().triggeredByAccessibilitySelectionChange) {
// Force UIKit to reload all EditorState-based UI; in particular, this includes text candidates.
Expand Down

0 comments on commit 027711e

Please sign in to comment.