Skip to content

Commit

Permalink
REGRESSION (r206853?): LayoutTest js/regress-141098.html failing
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=163046

Reviewed by Saam Barati.

This is attempt-to-fix patch since I cannot reproduce this flakiness.
We reduce the number of frames to back off from the stack overflow to
catch the closer frame limit to the actual stack limit.

* js/script-tests/regress-141098.js:


Canonical link: https://commits.webkit.org/180995@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@206947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Constellation committed Oct 8, 2016
1 parent 37e5407 commit 02a6653
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 1 deletion.
13 changes: 13 additions & 0 deletions LayoutTests/ChangeLog
@@ -1,3 +1,16 @@
2016-10-07 Yusuke Suzuki <utatane.tea@gmail.com>

REGRESSION (r206853?): LayoutTest js/regress-141098.html failing
https://bugs.webkit.org/show_bug.cgi?id=163046

Reviewed by Saam Barati.

This is attempt-to-fix patch since I cannot reproduce this flakiness.
We reduce the number of frames to back off from the stack overflow to
catch the closer frame limit to the actual stack limit.

* js/script-tests/regress-141098.js:

2016-10-07 Wenson Hsieh <wenson_hsieh@apple.com>

Unreviewed, mark a test as failing on iOS simulator
Expand Down
2 changes: 1 addition & 1 deletion LayoutTests/js/script-tests/regress-141098.js
Expand Up @@ -13,7 +13,7 @@ description("Regression test for https://webkit.org/b/141098. Make sure eval() p
// Under no circumstance should this test ever crash.
let countStart = 2;
let countIncrement = 8;
let numberOfFramesToBackoffFromStackOverflowPoint = 50;
let numberOfFramesToBackoffFromStackOverflowPoint = 10;

// backoffEverything is chosen to be -1 because a negative number will never be
// decremented to 0, and hence, will cause probeAndRecurse() to return out of every
Expand Down

0 comments on commit 02a6653

Please sign in to comment.