Skip to content

Commit

Permalink
Remove failing assert in JSC Options.cpp.
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=248971

Reviewed by Yusuke Suzuki.

We have tests that test this configuration, like
stress/ftl-osr-entry-order-reverse.js. We should
temporarily remove this assertion so that debug
tests pass.

* Source/JavaScriptCore/runtime/Options.cpp:
(JSC::Options::notifyOptionsChanged):

Canonical link: https://commits.webkit.org/257586@main
  • Loading branch information
Justin Michaud authored and Constellation committed Dec 8, 2022
1 parent 9777436 commit 0893db1
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion Source/JavaScriptCore/runtime/Options.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -747,7 +747,6 @@ void Options::notifyOptionsChanged()

// Do range checks where needed and make corrections to the options:
ASSERT(Options::thresholdForOptimizeAfterLongWarmUp() >= Options::thresholdForOptimizeAfterWarmUp());
ASSERT(Options::thresholdForOptimizeAfterWarmUp() >= Options::thresholdForOptimizeSoon());
ASSERT(Options::thresholdForOptimizeAfterWarmUp() >= 0);
ASSERT(Options::criticalGCMemoryThreshold() > 0.0 && Options::criticalGCMemoryThreshold() < 1.0);

Expand Down

0 comments on commit 0893db1

Please sign in to comment.