Skip to content

Commit

Permalink
editing/inserting/insert-paragraph-separator-with-html-elements-crash…
Browse files Browse the repository at this point in the history
….html is a consistent failure.

https://bugs.webkit.org/show_bug.cgi?id=260555>:
<rdar://114287454>

Reviewed by Ryosuke Niwa.

The test sets a requestAnimationFrame handler, and we need to wait for that to run.

* LayoutTests/editing/inserting/insert-paragraph-separator-with-html-elements-crash.html:
* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/267478@main
  • Loading branch information
mattwoodrow committed Aug 31, 2023
1 parent e9418af commit 099337e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
<!DOCTYPE html>
<script type="text/javascript">
if (window.testRunner)
if (window.testRunner) {
testRunner.dumpAsText();
testRunner.waitUntilDone();
}
console.log('The test PASS if it does not crash.')
requestAnimationFrame(function() {
document.documentElement.addEventListener("DOMNodeRemoved", function() {
Expand Down Expand Up @@ -42,5 +44,8 @@
document.execCommand('InsertParagraph');
}, {once: true});
oElement.outerHTML = "";

if (window.testRunner)
testRunner.notifyDone();
})
</script>
3 changes: 0 additions & 3 deletions LayoutTests/platform/mac/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -2864,9 +2864,6 @@ webkit.org/b/130490 media/video-remote-control-playpause.html [ Pass Timeout Cra

webkit.org/b/260529 [ Ventura+ x86_64 ] animations/suspend-resume-animation-events.html [ Pass Failure ]

# rdar://114291916 (REGRESSION (266884@main): [ Sonoma wk2 ] editing/inserting/insert-paragraph-separator-with-html-elements-crash.html is a consistent failure)
[ Sonoma+ ] editing/inserting/insert-paragraph-separator-with-html-elements-crash.html [ Failure ]

webkit.org/b/260870 [ Ventura+ ] imported/w3c/web-platform-tests/svg/import/metadata-example-01-t-manual.svg [ Failure ]

webkit.org/b/260912 [ Monterey+ Debug ] imported/w3c/web-platform-tests/dom/nodes/NodeList-static-length-getter-tampered-indexOf-1.html [ Timeout ]
Expand Down

0 comments on commit 099337e

Please sign in to comment.