Skip to content

Commit

Permalink
Merge r155509 - [GTK] Stop disabling deprecated symbols in debug builds
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=121145

Reviewed by Carlos Garcia Campos.

Disabling the dependencies' deprecated symbols in debug builds is only causing unnecessary
build failures. Compiler warnings are being thrown whenever a deprecated symbol is being
used, so a build failure is an overreach in this case.

* Source/autotools/SetupAutoconfHeader.m4:
  • Loading branch information
zdobersek authored and Žan Doberšek committed Sep 11, 2013
1 parent 08ad353 commit 0a54f60
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 9 deletions.
13 changes: 13 additions & 0 deletions ChangeLog
@@ -1,3 +1,16 @@
2013-09-11 Zan Dobersek <zdobersek@igalia.com>

[GTK] Stop disabling deprecated symbols in debug builds
https://bugs.webkit.org/show_bug.cgi?id=121145

Reviewed by Carlos Garcia Campos.

Disabling the dependencies' deprecated symbols in debug builds is only causing unnecessary
build failures. Compiler warnings are being thrown whenever a deprecated symbol is being
used, so a build failure is an overreach in this case.

* Source/autotools/SetupAutoconfHeader.m4:

2013-09-11 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed. Update NEWS and Versions.m4 for 2.1.91 release.
Expand Down
10 changes: 1 addition & 9 deletions Source/autotools/SetupAutoconfHeader.m4
@@ -1,12 +1,7 @@
# Configuration flags that are used throughout WebKitGTK+.
AC_DEFINE_UNQUOTED(GETTEXT_PACKAGE,"$GETTEXT_PACKAGE", [The gettext catalog name])

if test "$enable_debug" = "yes"; then
AC_DEFINE([GDK_PIXBUF_DISABLE_DEPRECATED], [1], [ ])
AC_DEFINE([GDK_DISABLE_DEPRECATED], [1], [ ])
AC_DEFINE([GTK_DISABLE_DEPRECATED], [1], [ ])
AC_DEFINE([PANGO_DISABLE_DEPRECATED], [1], [ ])
else
if test "$enable_debug" = "no"; then
AC_DEFINE([NDEBUG], [1], [Define to disable debugging])
fi

Expand Down Expand Up @@ -59,9 +54,6 @@ fi

if test "$enable_video" = "yes" || test "$enable_web_audio" = "yes"; then
AC_DEFINE([WTF_USE_GSTREAMER], [1], [ ])
if test "$enable_debug" = "yes"; then
AC_DEFINE([GST_DISABLE_DEPRECATED], [1], [ ])
fi
fi

if test "$enable_web_audio" = "yes"; then
Expand Down

0 comments on commit 0a54f60

Please sign in to comment.