Skip to content

Commit

Permalink
Stop resolving border's current color to some hardcoded value
Browse files Browse the repository at this point in the history 
https://bugs.webkit.org/show_bug.cgi?id=258725

Reviewed by Tim Nguyen.

We currently return some hardcoded value when resolving
current color for border properties.
I can't think of any good reason for doing this.
The result can be unexpected for web developers.

* Source/WebCore/css/html.css:
(hr):
(#if defined(WTF_PLATFORM_IOS_FAMILY) && WTF_PLATFORM_IOS_FAMILY):
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::colorResolvingCurrentColor const):

Canonical link: https://commits.webkit.org/266134@main
  • Loading branch information
@obyknovenius
obyknovenius committed Jul 18, 2023
1 parent 0b3aac1 commit 0aa032e
Show file tree
Hide file tree
Showing 1,627 changed files with 3,560 additions and 3,548 deletions.
4 changes: 2 additions & 2 deletions LayoutTests/css3/flexbox/button-expected.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ layer at (0,0) size 800x254
text run at (431,20) width 74: "bug 110654"
RenderText {#text} at (505,20) size 4x19
text run at (505,20) width 4: "."
RenderBlock {HR} at (0,48) size 784x2 [border: (1px inset #000000)]
RenderBlock {HR} at (0,48) size 784x2 [color=#808080] [border: (1px inset #808080)]
RenderBlock (anonymous) at (0,58) size 784x66
RenderText {#text} at (0,0) size 76x19
text run at (0,0) width 76: "Simple case."
Expand All @@ -22,7 +22,7 @@ layer at (0,0) size 800x254
RenderBR {BR} at (20,20) size 0x19
RenderButton {INPUT} at (2,42) size 16x22 [bgcolor=#DDDDDD] [border: (2px outset #DDDDDD)]
RenderBR {BR} at (20,46) size 0x19
RenderBlock {HR} at (0,132) size 784x2 [border: (1px inset #000000)]
RenderBlock {HR} at (0,132) size 784x2 [color=#808080] [border: (1px inset #808080)]
RenderBlock (anonymous) at (0,142) size 784x96
RenderText {#text} at (0,0) size 739x19
text run at (0,0) width 739: "Empty <button> and <input type=button> with overflow: scroll;. The presence of the scrollbar should not shrink the button."
Expand Down
4 changes: 2 additions & 2 deletions LayoutTests/fast/css/resize-corner-tracking-expected.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ layer at (0,0) size 800x600
layer at (0,0) size 800x600
RenderBlock {HTML} at (0,0) size 800x600
RenderBody {BODY} at (8,8) size 784x584
RenderBlock {HR} at (0,0) size 784x2 [border: (1px inset #000000)]
RenderBlock {HR} at (0,0) size 784x2 [color=#808080] [border: (1px inset #808080)]
RenderBlock {P} at (0,18) size 784x18
RenderText {#text} at (0,0) size 53x18
text run at (0,0) width 53: "Test for "
Expand All @@ -16,7 +16,7 @@ layer at (0,0) size 800x600
text run at (405,0) width 317: "Resize corner does not track the mouse accurately"
RenderText {#text} at (722,0) size 4x18
text run at (722,0) width 4: "."
RenderBlock {HR} at (0,52) size 784x2 [border: (1px inset #000000)]
RenderBlock {HR} at (0,52) size 784x2 [color=#808080] [border: (1px inset #808080)]
RenderBlock (anonymous) at (0,187) size 784x361
RenderText {#text} at (169,107) size 4x18
text run at (169,107) width 4: " "
Expand Down
8 changes: 4 additions & 4 deletions LayoutTests/fast/forms/auto-fill-button/input-auto-fill-button-expected.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,20 @@ layer at (0,0) size 800x600
RenderText {#text} at (0,0) size 503x18
text run at (0,0) width 503: "This tests that the AutoFill button renders. It can only be tested in the test tool."
RenderBlock {DIV} at (0,34) size 784x23
RenderTextControl {INPUT} at (2,2) size 137x19 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
RenderTextControl {INPUT} at (2,2) size 137x19 [bgcolor=#FFFFFF] [border: (2px inset #808080)]
RenderFlexibleBox {DIV} at (3,3) size 131x13
RenderBlock {DIV} at (0,0) size 111x13
RenderText {#text} at (140,2) size 5x18
text run at (140,2) width 5: " "
RenderTextControl {INPUT} at (146,2) size 137x19 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
RenderTextControl {INPUT} at (146,2) size 137x19 [bgcolor=#FFFFFF] [border: (2px inset #808080)]
RenderFlexibleBox {DIV} at (3,3) size 131x13
RenderBlock {DIV} at (0,0) size 111x13
RenderText {#text} at (284,2) size 5x18
text run at (284,2) width 5: " "
RenderTextControl {INPUT} at (290,2) size 138x19 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
RenderTextControl {INPUT} at (290,2) size 138x19 [bgcolor=#FFFFFF] [border: (2px inset #808080)]
RenderFlexibleBox {DIV} at (3,3) size 131x13
RenderBlock {DIV} at (0,0) size 111x13
RenderTextControl {INPUT} at (431,2) size 137x19 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
RenderTextControl {INPUT} at (431,2) size 137x19 [bgcolor=#FFFFFF] [border: (2px inset #808080)]
RenderFlexibleBox {DIV} at (3,3) size 131x13
RenderBlock {DIV} at (0,0) size 111x13
layer at (13,47) size 110x13
Expand Down
12 changes: 6 additions & 6 deletions LayoutTests/fast/forms/auto-fill-button/input-contacts-auto-fill-button-expected.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,28 +7,28 @@ layer at (0,0) size 800x104
RenderText {#text} at (0,0) size 598x18
text run at (0,0) width 598: "This tests that the Address Book AutoFill button renders. It can only be tested in the test tool."
RenderBlock {DIV} at (0,34) size 784x46
RenderTextControl {INPUT} at (2,2) size 137x19 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
RenderTextControl {INPUT} at (2,2) size 137x19 [bgcolor=#FFFFFF] [border: (2px inset #808080)]
RenderFlexibleBox {DIV} at (3,3) size 131x13
RenderBlock {DIV} at (0,0) size 104x13
RenderText {#text} at (140,2) size 5x18
text run at (140,2) width 5: " "
RenderTextControl {INPUT} at (146,2) size 137x19 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
RenderTextControl {INPUT} at (146,2) size 137x19 [bgcolor=#FFFFFF] [border: (2px inset #808080)]
RenderFlexibleBox {DIV} at (3,3) size 131x13
RenderBlock {DIV} at (0,0) size 104x13
RenderText {#text} at (284,2) size 5x18
text run at (284,2) width 5: " "
RenderTextControl {INPUT} at (290,2) size 138x19 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
RenderTextControl {INPUT} at (290,2) size 138x19 [bgcolor=#FFFFFF] [border: (2px inset #808080)]
RenderFlexibleBox {DIV} at (3,3) size 131x13
RenderBlock {DIV} at (0,0) size 104x13
RenderText {#text} at (429,2) size 5x18
text run at (429,2) width 5: " "
RenderTextControl {INPUT} at (435,2) size 137x19 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
RenderTextControl {INPUT} at (435,2) size 137x19 [bgcolor=#FFFFFF] [border: (2px inset #808080)]
RenderFlexibleBox {DIV} at (3,3) size 131x13
RenderBlock {DIV} at (0,0) size 104x13
RenderTextControl {INPUT} at (575,2) size 137x19 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
RenderTextControl {INPUT} at (575,2) size 137x19 [bgcolor=#FFFFFF] [border: (2px inset #808080)]
RenderFlexibleBox {DIV} at (3,3) size 131x13
RenderBlock {DIV} at (0,0) size 104x13
RenderTextControl {INPUT} at (2,25) size 137x19 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
RenderTextControl {INPUT} at (2,25) size 137x19 [bgcolor=#FFFFFF] [border: (2px inset #808080)]
RenderFlexibleBox {DIV} at (3,3) size 131x13
RenderBlock {DIV} at (0,0) size 104x13
layer at (13,55) size 103x13
Expand Down
8 changes: 4 additions & 4 deletions LayoutTests/fast/forms/auto-fill-button/input-credit-card-auto-fill-button-expected.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,22 +8,22 @@ layer at (0,0) size 800x77
text run at (0,0) width 196: "This tests that the Credit Card "
text run at (195,0) width 387: "AutoFill button renders. It can only be tested in the test tool."
RenderBlock {DIV} at (0,34) size 784x19
RenderTextControl {INPUT} at (0,0) size 147x19 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
RenderTextControl {INPUT} at (0,0) size 147x19 [bgcolor=#FFFFFF] [border: (2px inset #808080)]
RenderFlexibleBox {DIV} at (3,3) size 141x13
RenderBlock {DIV} at (0,0) size 114x13
RenderText {#text} at (146,0) size 5x18
text run at (146,0) width 5: " "
RenderTextControl {INPUT} at (150,0) size 148x19 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
RenderTextControl {INPUT} at (150,0) size 148x19 [bgcolor=#FFFFFF] [border: (2px inset #808080)]
RenderFlexibleBox {DIV} at (3,3) size 141x13
RenderBlock {DIV} at (0,0) size 114x13
RenderText {#text} at (297,0) size 5x18
text run at (297,0) width 5: " "
RenderTextControl {INPUT} at (301,0) size 148x19 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
RenderTextControl {INPUT} at (301,0) size 148x19 [bgcolor=#FFFFFF] [border: (2px inset #808080)]
RenderFlexibleBox {DIV} at (3,3) size 141x13
RenderBlock {DIV} at (0,0) size 114x13
RenderText {#text} at (448,0) size 5x18
text run at (448,0) width 5: " "
RenderTextControl {INPUT} at (452,0) size 148x19 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
RenderTextControl {INPUT} at (452,0) size 148x19 [bgcolor=#FFFFFF] [border: (2px inset #808080)]
RenderFlexibleBox {DIV} at (3,3) size 141x13
RenderBlock {DIV} at (0,0) size 114x13
layer at (11,53) size 114x13
Expand Down
2 changes: 1 addition & 1 deletion LayoutTests/fast/forms/button-inner-block-reuse-expected.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,4 @@ layer at (0,0) size 800x600
RenderInline {SPAN} at (0,0) size 0x0
RenderText {#text} at (0,0) size 0x0
layer at (8,120) size 784x2 clip at (0,0) size 0x0
RenderBlock {HR} at (0,112) size 784x2 [border: (1px inset #000000)]
RenderBlock {HR} at (0,112) size 784x2 [color=#808080] [border: (1px inset #808080)]
Loading

0 comments on commit 0aa032e

Please sign in to comment.