Unreviewed, reverting 267565@main.

https://bugs.webkit.org/show_bug.cgi?id=261766

caused text to go missing on GitHub PR pages

Reverted changeset:

"Add mutation events tests for ContainerNode::replaceChildren and refactor the code"
https://bugs.webkit.org/show_bug.cgi?id=261016
https://commits.webkit.org/267565@main

Canonical link: https://commits.webkit.org/268143@main

Source/WebCore/dom/ContainerNode.cpp

@@ -1086,32 +1086,27 @@ ExceptionOr<void> ContainerNode::prepend(FixedVector<NodeOrString>&& vector)
 // https://dom.spec.whatwg.org/#dom-parentnode-replacechildren
 ExceptionOr<void> ContainerNode::replaceChildren(FixedVector<NodeOrString>&& vector)
 {
-    auto targets = convertNodesOrStringsIntoNodeVector(WTFMove(vector));
-    for (auto& node : targets) {
-        if (auto result = ensurePreInsertionValidity(node, nullptr); result.hasException())
-            return result.releaseException();
-        if (auto result = node->remove(); result.hasException())
-            return result.releaseException();
+    // step 1
+    auto result = convertNodesOrStringsIntoNode(WTFMove(vector));
+    if (result.hasException())
+        return result.releaseException();
+    auto node = result.releaseReturnValue();
+
+    // step 2
+    if (node) {
+        if (auto checkResult = ensurePreInsertionValidity(*node, nullptr); checkResult.hasException())
+            return checkResult;
     }
 
     // step 3
     Ref protectedThis { *this };
     ChildListMutationScope mutation(*this);
     NodeVector removedChildren;
-    auto didRemoveElements = removeAllChildrenWithScriptAssertion(ChildChange::Source::API, removedChildren, DeferChildrenChanged::Yes);
-    auto replacedAllChildren = (targets.size() && is<Element>(targets[0]))
-        || didRemoveElements == DidRemoveElements::Yes ? ReplacedAllChildren::YesIncludingElements : ReplacedAllChildren::YesNotIncludingElements;
+    removeAllChildrenWithScriptAssertion(ChildChange::Source::API, removedChildren, DeferChildrenChanged::No);
 
-    for (auto& child : targets) {
-        if (child->parentNode())
-            break; // Exit early if mutation event listeners inserted child to elsewhere.
-
-        executeNodeInsertionWithScriptAssertion(*this, child, nullptr, ChildChange::Source::API, replacedAllChildren, [&] {
-            InspectorInstrumentation::willInsertDOMNode(document(), *this);
-            child->setTreeScopeRecursively(treeScope());
-            appendChildCommon(child);
-        });
-        replacedAllChildren = ReplacedAllChildren::No;
+    if (node) {
+        if (auto appendResult = appendChildWithoutPreInsertionValidityCheck(*node); appendResult.hasException())
+            return appendResult;
     }
 
     rebuildSVGExtensionsElementsIfNecessary();

Source/WebCore/dom/Node.cpp

@@ -575,12 +575,12 @@ static RefPtr<Node> firstFollowingSiblingNotInNodeSet(Node& context, const HashS
     return nullptr;
 }
 
-Vector<Ref<Node>, 1> Node::convertNodesOrStringsIntoNodeVector(FixedVector<NodeOrString>&& nodeOrStringVector)
+ExceptionOr<RefPtr<Node>> Node::convertNodesOrStringsIntoNode(FixedVector<NodeOrString>&& nodeOrStringVector)
 {
     if (nodeOrStringVector.isEmpty())
-        return { };
+        return nullptr;
 
-    Vector<Ref<Node>, 1> nodes;
+    Vector<Ref<Node>> nodes;
     nodes.reserveInitialCapacity(nodeOrStringVector.size());
     for (auto& variant : nodeOrStringVector) {
         WTF::switchOn(variant,
@@ -589,19 +589,11 @@ Vector<Ref<Node>, 1> Node::convertNodesOrStringsIntoNodeVector(FixedVector<NodeO
         );
     }
 
-    return nodes;
-}
-
-ExceptionOr<RefPtr<Node>> Node::convertNodesOrStringsIntoNode(FixedVector<NodeOrString>&& nodeOrStringVector)
-{
-    auto nodeVector = convertNodesOrStringsIntoNodeVector(WTFMove(nodeOrStringVector));
-    if (nodeVector.isEmpty())
-        return nullptr;
-    if (nodeVector.size() == 1)
-        return RefPtr<Node> { WTFMove(nodeVector[0]) };
+    if (nodes.size() == 1)
+        return RefPtr<Node> { WTFMove(nodes.first()) };
 
     auto nodeToReturn = DocumentFragment::create(document());
-    for (auto& node : nodeVector) {
+    for (auto& node : nodes) {
         auto appendResult = nodeToReturn->appendChild(node);
         if (appendResult.hasException())
             return appendResult.releaseException();

Source/WebCore/dom/Node.h

@@ -711,7 +711,6 @@ class Node : public EventTarget {
     void updateAncestorsForStyleRecalc();
     void markAncestorsForInvalidatedStyle();
 
-    Vector<Ref<Node>, 1> convertNodesOrStringsIntoNodeVector(FixedVector<NodeOrString>&&);
     ExceptionOr<RefPtr<Node>> convertNodesOrStringsIntoNode(FixedVector<NodeOrString>&&);
 
 private: