Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Charset of blobs are incorrectly ignored
https://bugs.webkit.org/show_bug.cgi?id=243953 Reviewed by Geoffrey Garen. We were failing to set the text encoding name on the ResourceResponse based on the charset present in the Content-Type HTTP header. Normally, it gets initialized lazily by ResourceResponse::textEncodingName() based on the Content-Type header. However, this doesn't happen for Blobs because there is no underlying NSURLRequest. * LayoutTests/imported/w3c/web-platform-tests/FileAPI/url/url-charset.window-expected.txt: * Source/WebCore/platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::notifyResponseOnSuccess): * Source/WebCore/platform/network/HTTPParsers.h: * Source/WebKit/NetworkProcess/NetworkDataTaskBlob.cpp: (WebKit::NetworkDataTaskBlob::dispatchDidReceiveResponse): Canonical link: https://commits.webkit.org/253458@main
- Loading branch information
Showing
4 changed files
with
5 additions
and
3 deletions.
There are no files selected for viewing
4 changes: 2 additions & 2 deletions
4
LayoutTests/imported/w3c/web-platform-tests/FileAPI/url/url-charset.window-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
|
||
FAIL Blob charset should override any auto-detected charset. assert_equals: expected "UTF-8" but got "windows-1252" | ||
FAIL Blob charset should override <meta charset>. assert_equals: expected "UTF-8" but got "windows-1252" | ||
PASS Blob charset should override any auto-detected charset. | ||
PASS Blob charset should override <meta charset>. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters