Skip to content

Commit

Permalink
[JSC] re-enable some no-longer-failing tests on armv7
Browse files Browse the repository at this point in the history
Test gardening.

Unreviewed test gardening.

These tests now pass on armv7.

* JSTests/stress/sampling-profiler-microtasks.js:
* JSTests/wasm/function-tests/trap-load-shared.js:
* JSTests/wasm/stress/simple-inline-stacktrace-with-catch.js:
* JSTests/wasm/stress/simple-inline-stacktrace.js:
* PerformanceTests/SunSpider/shadow-chicken.yaml:

Canonical link: https://commits.webkit.org/274604@main
  • Loading branch information
eugeneia authored and jjgriego committed Feb 14, 2024
1 parent cb7ebb2 commit 138b7cc
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 5 deletions.
1 change: 0 additions & 1 deletion JSTests/stress/sampling-profiler-microtasks.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
//@ skip if $architecture == "arm"

var abort = $vm.abort;

Expand Down
2 changes: 1 addition & 1 deletion JSTests/wasm/function-tests/trap-load-shared.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//@ skip if $architecture != "arm64" && $architecture != "x86_64"
//@ skip if $architecture != "arm64" && $architecture != "x86_64" && $architecture != "arm"

import Builder from '../Builder.js'
import * as assert from '../assert.js'
Expand Down
1 change: 0 additions & 1 deletion JSTests/wasm/stress/simple-inline-stacktrace-with-catch.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
//@ skip if $architecture == 'arm'
var wasm_code = read('simple-inline-stacktrace-with-catch.wasm', 'binary')
var wasm_module = new WebAssembly.Module(wasm_code);
let throwCounter = 0
Expand Down
1 change: 0 additions & 1 deletion JSTests/wasm/stress/simple-inline-stacktrace.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
//@ skip if $architecture == "arm"

var wasm_code = read('simple-inline-stacktrace.wasm', 'binary')
var wasm_module = new WebAssembly.Module(wasm_code);
Expand Down
2 changes: 1 addition & 1 deletion PerformanceTests/SunSpider/shadow-chicken.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,5 @@
cmd: runShadowChicken

- path: tests/v8-v6
cmd: if 'arm' == $architecture; skip; else runShadowChicken; end
cmd: runShadowChicken

0 comments on commit 138b7cc

Please sign in to comment.