Skip to content

Commit

Permalink
REGRESSION (iOS 17.4 Beta): No incoming video in Teams VA
Browse files Browse the repository at this point in the history
rdar://122859173
https://bugs.webkit.org/show_bug.cgi?id=269281

Reviewed by Brent Fulgham.

WebRTC applicartions typically do not care about reordering since it hits the latency.
We are thus setting the window size to 0 when AVC is false, which is the case for libwebrtc decoders.
WebCodecs websites that had issues with reordering are using AVC, so should not be broken by this change.

* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderH264.mm:
(-[RTCVideoDecoderH264 decodeData:size:timeStamp:]):

Canonical link: https://commits.webkit.org/274581@main
  • Loading branch information
youennf committed Feb 13, 2024
1 parent a25a854 commit 1392a12
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,8 @@ - (NSInteger)decodeData:(const uint8_t *)data
rtc::ScopedCFTypeRef<CMVideoFormatDescriptionRef> inputFormat =
rtc::ScopedCF(webrtc::CreateVideoFormatDescription(data, size));
if (inputFormat) {
_reorderQueue.setReorderSize(webrtc::ComputeH264ReorderSizeFromAnnexB(data, size));
// FIXME: Reenable reorder size computation for AnnexB decoders, once feasible (rdar://122902399).
_reorderQueue.setReorderSize(_useAVC ? webrtc::ComputeH264ReorderSizeFromAnnexB(data, size) : 0);
// Check if the video format has changed, and reinitialize decoder if
// needed.
if (!CMFormatDescriptionEqual(inputFormat.get(), _videoFormat)) {
Expand Down

0 comments on commit 1392a12

Please sign in to comment.