-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[WebGPU] Invalid command buffers need to get dealloc'ed in a timely f…
…ashion https://bugs.webkit.org/show_bug.cgi?id=273328 <radar://127121787> Reviewed by Tadeu Zagallo. Discard invalid command buffers instead of submitting them to the driver which results in incorrect behavior and/or uintended side effects. Re-land with CTS test regressions fixed: bug was we would allow an command buffer to get invalidated after it's underlying Metal buffer was already submitted. * Source/WebGPU/WebGPU/CommandBuffer.h: (WebGPU::CommandBuffer::create): * Source/WebGPU/WebGPU/CommandBuffer.mm: (WebGPU::CommandBuffer::CommandBuffer): (WebGPU::CommandBuffer::makeInvalid): * Source/WebGPU/WebGPU/CommandEncoder.h: (WebGPU::CommandEncoder::create): * Source/WebGPU/WebGPU/CommandEncoder.mm: (WebGPU::Device::createCommandEncoder): (WebGPU::CommandEncoder::CommandEncoder): (WebGPU::CommandEncoder::makeInvalid): (WebGPU::CommandEncoder::finish): * Source/WebGPU/WebGPU/MetalSPI.h: * Source/WebGPU/WebGPU/PresentationContextIOSurface.mm: * Source/WebGPU/WebGPU/Queue.h: * Source/WebGPU/WebGPU/Queue.mm: (WebGPU::Queue::ensureBlitCommandEncoder): (WebGPU::Queue::commandBufferWithDescriptor): Canonical link: https://commits.webkit.org/278622@main
- Loading branch information
1 parent
4edfa39
commit 1399a72
Showing
8 changed files
with
45 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters