svg/compositing/transform-change-repainting-viewBox.html should not e…

…nable layer borders https://bugs.webkit.org/show_bug.cgi?id=267588 rdar://121052864 Reviewed by Tim Nguyen. Turn off layer borders, remove pixel tolerance, and de-tab. * LayoutTests/compositing/updates/animation-non-composited.html: Drive-by nit fix. * LayoutTests/svg/compositing/transform-change-repainting-viewBox-expected.html: * LayoutTests/svg/compositing/transform-change-repainting-viewBox.html: Canonical link: https://commits.webkit.org/273090@main
WebKit · Jan 16, 2024 · 15ebca4 · 15ebca4
1 parent 9b4ea11
commit 15ebca4
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 23 deletions.
diff --git a/LayoutTests/compositing/updates/animation-non-composited.html b/LayoutTests/compositing/updates/animation-non-composited.html
@@ -30,7 +30,7 @@
         internals.updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks();
         initialCompositingUpdateCount = internals.compositingUpdateCount();
     }
-}, 0);
+});
 
 test.onanimationend = () => {
     if (!window.internals)

diff --git a/LayoutTests/svg/compositing/transform-change-repainting-viewBox-expected.html b/LayoutTests/svg/compositing/transform-change-repainting-viewBox-expected.html
@@ -9,40 +9,35 @@
             transform-origin: 50% 50%;
             transform-box: border-box;
             transform: translateZ(0);
-	}
+        }
 
         .animating2 {
             transform-origin: 50% 50%;
             transform-box: border-box;
             transform: rotate(25deg) translateZ(0);
-	}
+        }
 
         .animating3 {
             transform-origin: 50% 50%;
             transform-box: border-box;
-	    transform: rotate(45deg) translateZ(0);
+            transform: rotate(45deg) translateZ(0);
             fill: green;
         }
     </style>
     <script type="text/javascript">
         if (window.testRunner)
             testRunner.waitUntilDone();
 
-        if (window.internals) {
-            internals.settings.setShowRepaintCounter(true);
-            internals.settings.setShowDebugBorders(true);
-        }
-
         window.addEventListener('load', () => {
             requestAnimationFrame(() => {
                 document.getElementById('rect').setAttribute("class", "animating2");
-		requestAnimationFrame(() => {
+                requestAnimationFrame(() => {
                     document.getElementById('rect').setAttribute("class", "animating3");
                     if (window.testRunner)
-			testRunner.notifyDone();
-		    });
-		});
-	    }, false);
+                        testRunner.notifyDone();
+                });
+            });
+        }, false);
     </script>
 </head>
 <body>

diff --git a/LayoutTests/svg/compositing/transform-change-repainting-viewBox.html b/LayoutTests/svg/compositing/transform-change-repainting-viewBox.html
@@ -1,18 +1,17 @@
 <!DOCTYPE html> <!-- webkit-test-runner [ LayerBasedSVGEngineEnabled=true ] -->
 <html>
 <head>
-    <meta name="fuzzy" content="maxDifference=35; totalPixels=12" />
     <title>Tests that SVG documents with viewBox don't trigger unnecessary repaints during animations.</title>
     <style>
         svg { border: 1px solid black; }
 
         #animating {
             transform-origin: 50% 50%;
             transform-box: border-box;
-	    transform: translateZ(0);
+            transform: translateZ(0);
 
             animation: rotation 1s 1s;
-	    animation-fill-mode: forwards;
+            animation-fill-mode: forwards;
         }
 
         @keyframes rotation {
@@ -31,11 +30,6 @@
             ["rotation", 1.5, "animating", "webkitTransform", "matrix(0.707107, 0.707107, -0.707107, 0.707107, 0, 0)", 0],
         ];
 
-        if (window.internals) {
-            internals.settings.setShowRepaintCounter(true);
-            internals.settings.setShowDebugBorders(true);
-        }
-
         var doPixelTest = true;
         var disablePauseAPI = true;
         runAnimationTest(expectedValues, null, undefined, disablePauseAPI, doPixelTest);
@@ -45,6 +39,6 @@
     <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 200 200" width="500" height="300">    
         <rect id="animating" x="10" y="10" width="180" height="180" fill="green"/>
     </svg>
-    <div id="result"/>
+    <div id="result"></div>
 </body>
 </html>