Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
REGRESSION (r109593): Clicking after last inline element could cause a crash. https://bugs.webkit.org/show_bug.cgi?id=142880 rdar://problem/17222294 Reviewed by Ryosuke Niwa. Test: editing/selection/click-after-last-inline-crash.html * rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::closestLeafChildForLogicalLeftPosition): LayoutTests: Web Inspector: Adopt ES6 Class Syntax for all Model Objects https://bugs.webkit.org/show_bug.cgi?id=142858 Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-03-19 Reviewed by Timothy Hatcher. * inspector/model/parse-script-syntax-tree.html: This test was calling a constructor without "new". Class syntax enforces "new" and threw an exception.
- Loading branch information
1 parent
1bc7421
commit 16a4b4d
Showing
5 changed files
with
56 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
LayoutTests/editing/selection/click-after-last-inline-crash-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
Click after the end of the line with link. | ||
|
||
This is a link | ||
|
||
It should NOT crash! | ||
|
||
PASS |
23 changes: 23 additions & 0 deletions
23
LayoutTests/editing/selection/click-after-last-inline-crash.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
<html> | ||
<body> | ||
<div style="border: solid red 2px;"> | ||
Click after the end of the line with link.<br><br><a id='test' href="http://aftershock.su/?q=node/259078">This is a link</a><wbr><br><br>It should NOT crash!<br><br> | ||
</div> | ||
</body> | ||
<script> | ||
if (window.testRunner) { | ||
testRunner.dumpAsText(); | ||
|
||
if (!window.eventSender) | ||
document.writeln('This test requires eventSender'); | ||
else { | ||
var testElement = document.getElementById('test'); | ||
eventSender.mouseMoveTo(testElement.offsetLeft + testElement.offsetWidth + 50, testElement.offsetTop + 5); | ||
eventSender.mouseDown(); | ||
eventSender.mouseUp(); | ||
document.writeln('PASS'); | ||
} | ||
} | ||
|
||
</script> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters