Skip to content

Commit

Permalink
[WebGPU] Texture sample type is unnecessarily generated against auto-…
Browse files Browse the repository at this point in the history
…generated layouts

https://bugs.webkit.org/show_bug.cgi?id=267093
<radar://120487902>

Reviewed by Tadeu Zagallo.

The sample type of textures for auto-generated layouts is always a constant,
so it is not possible to validate them during bind group creation.

This was observed running the resource_init validation suite, which is currently
not running on EWS due to timeouts.

* Source/WebGPU/WebGPU/BindGroup.mm:
(WebGPU::Device::createBindGroup):

Canonical link: https://commits.webkit.org/272709@main
  • Loading branch information
mwyrzykowski committed Jan 5, 2024
1 parent a97369f commit 1700786
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Source/WebGPU/WebGPU/BindGroup.mm
Original file line number Diff line number Diff line change
Expand Up @@ -941,7 +941,7 @@ static bool validateSamplerType(WGPUSamplerBindingType type, const Sampler& samp
generateAValidationError("Bind group entry multisampled state does not match underlying texture"_s);
return BindGroup::createInvalid(*this);
}
if (!validateTextureSampleType(textureEntry, apiTextureView)) {
if (!bindGroupLayout.isAutoGenerated() && !validateTextureSampleType(textureEntry, apiTextureView)) {
generateAValidationError("Bind group entry sampleType does not match TextureView sampleType"_s);
return BindGroup::createInvalid(*this);
}
Expand Down

0 comments on commit 1700786

Please sign in to comment.