EWS pulls the wrong revision when checking out the tree for testing f…

…or PRs

https://bugs.webkit.org/show_bug.cgi?id=248725
rdar://102964437

Reviewed by Alexey Proskuryakov and Aakash Jain.

After https://commits.webkit.org/257193@main, PRs are no longer testing against
the ews revision and are instead testing against tip-of-tree, which is incorrect.

* Tools/CISupport/ews-build/steps.py:
(CheckOutSpecificRevision.doStepIf): Do step for PRs as well as patches.
* Tools/CISupport/ews-build/steps_unittest.py:
(TestCheckOutSpecificRevision.test_skip_pr): Deleted.

Canonical link: https://commits.webkit.org/257373@main

Tools/CISupport/ews-build/steps.py

@@ -721,7 +721,7 @@ def __init__(self, **kwargs):
         super(CheckOutSpecificRevision, self).__init__(logEnviron=False, **kwargs)
 
     def doStepIf(self, step):
-        return self.getProperty('ews_revision', False) and not self.getProperty('github.number', False)
+        return self.getProperty('ews_revision', False)
 
     def hideStepIf(self, results, step):
         return not self.doStepIf(step)

Tools/CISupport/ews-build/steps_unittest.py

@@ -3203,14 +3203,6 @@ def test_skip(self):
         self.expectOutcome(result=SKIPPED, state_string='Checked out required revision (skipped)')
         return self.runStep()
 
-    def test_skip_pr(self):
-        self.setupStep(CheckOutSpecificRevision())
-        self.setProperty('github.number', '1234')
-        self.setProperty('ews_revision', '1a3425cb92dbcbca12a10aa9514f1b77c76dc26')
-        self.expectHidden(True)
-        self.expectOutcome(result=SKIPPED, state_string='Checked out required revision (skipped)')
-        return self.runStep()
-
 
 class TestCleanWorkingDirectory(BuildStepMixinAdditions, unittest.TestCase):
     def setUp(self):