Skip to content

Commit

Permalink
NEW TEST[ MacOS arm64 ] media/mediacapabilities/vp9-hw.html is a cons…
Browse files Browse the repository at this point in the history
…tant failure

https://bugs.webkit.org/show_bug.cgi?id=270256
rdar://123790055

Reviewed by Eric Carlson.

vp9HardwareDecoderAvailable() returns false in DumpRenderTree which conflicts with Internals::isHardwareVP9DecoderExpected.
We restrict the test to WebKit2 to workaround this limitation.

* LayoutTests/media/mediacapabilities/vp9-hw.html:
* LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/275621@main
  • Loading branch information
youennf committed Mar 4, 2024
1 parent 11d5d62 commit 1866fce
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion LayoutTests/media/mediacapabilities/vp9-hw.html
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
if (!result.supported)
return;

if (window.internals && internals.isHardwareVP9DecoderExpected())
if (window.internals && window.testRunner && testRunner.isWebKit2 && internals.isHardwareVP9DecoderExpected())
assert_true(result.powerEfficient);
}, "VP9 powerEfficient for webrtc with hardware VP9 if any");

Expand Down
2 changes: 0 additions & 2 deletions LayoutTests/platform/mac-wk1/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -2794,8 +2794,6 @@ webkit.org/b/270133 [ Sonoma+ ] imported/w3c/web-platform-tests/accname/name/com
[ Sonoma+ ] imported/w3c/web-platform-tests/css/filter-effects/css-filters-animation-grayscale.html [ ImageOnlyFailure ]
[ Sonoma+ ] imported/w3c/web-platform-tests/css/filter-effects/css-filters-animation-sepia.html [ ImageOnlyFailure ]

webkit.org/b/270256 [ Monterey+ arm64 ] media/mediacapabilities/vp9-hw.html [ Failure ]

webkit.org/b/270273 [ Monterey+ Debug ] imported/w3c/web-platform-tests/scroll-animations/css/animation-inactive-outside-range-test.html [ Skip ]

webkit.org/b/270274 [ Monterey+ Debug ] imported/w3c/web-platform-tests/scroll-animations/css/animation-fill-outside-range-test.html [ Skip ]
Expand Down

0 comments on commit 1866fce

Please sign in to comment.