Skip to content

Commit

Permalink
[Windows] Update buildbot TestJSCFactory to get requirements for winc…
Browse files Browse the repository at this point in the history
…airo

https://bugs.webkit.org/show_bug.cgi?id=256070

Reviewed by Jonathan Bedard.

Add step for wincairo TestJSCFactory to get the requirements
like we do in TestFactory after extracting the built product.

* Tools/CISupport/build-webkit-org/factories.py:
(TestJSCFactory.__init__):
* Tools/CISupport/build-webkit-org/factories_unittest.py:
(TestExpectedBuildSteps):

Canonical link: https://commits.webkit.org/263508@main
  • Loading branch information
foopoiuyt committed Apr 28, 2023
1 parent 3cf2ce9 commit 19ef7f2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions Tools/CISupport/build-webkit-org/factories.py
Expand Up @@ -198,6 +198,8 @@ def __init__(self, platform, configuration, architectures, additionalArguments=N
Factory.__init__(self, platform, configuration, architectures, False, additionalArguments, device_model)
self.addStep(DownloadBuiltProduct())
self.addStep(ExtractBuiltProduct())
if platform == 'wincairo':
self.addStep(InstallWinCairoDependencies())
self.addStep(RunJavaScriptCoreTests())


Expand Down
2 changes: 2 additions & 0 deletions Tools/CISupport/build-webkit-org/factories_unittest.py
Expand Up @@ -1235,6 +1235,7 @@ class TestExpectedBuildSteps(unittest.TestCase):
'delete-stale-build-files',
'download-built-product',
'extract-built-product',
'wincairo-requirements',
'jscore-test'
],
'WinCairo-64-bit-Debug-Build': [
Expand Down Expand Up @@ -1309,6 +1310,7 @@ class TestExpectedBuildSteps(unittest.TestCase):
'delete-stale-build-files',
'download-built-product',
'extract-built-product',
'wincairo-requirements',
'jscore-test'
],
'PlayStation-Debug-Build': [
Expand Down

0 comments on commit 19ef7f2

Please sign in to comment.