Skip to content

Commit

Permalink
[WebGPU] Queue should not allow command buffer to be committed twice
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=273585
<radar://127364831>

Reviewed by Cameron McCormack.

Check the command buffer status during validation to ensure
addCompleted / scheduled handler doesn't occur after commit.

* LayoutTests/TestExpectations:
* LayoutTests/fast/webgpu/fuzz-273585-expected.txt: Added.
* LayoutTests/fast/webgpu/fuzz-273585.html: Added.
Add regression test.

* Source/WebGPU/WebGPU/Queue.mm:
(WebGPU::Queue::errorValidatingSubmit const):

Canonical link: https://commits.webkit.org/278362@main
  • Loading branch information
mwyrzykowski committed May 4, 2024
1 parent c002113 commit 1aa9df8
Show file tree
Hide file tree
Showing 4 changed files with 21,636 additions and 2 deletions.
2 changes: 2 additions & 0 deletions LayoutTests/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -2116,6 +2116,8 @@ webkit.org/b/139639 [ Debug ] cssom/non-subpixel-scroll-top-left-values.html [ S
[ Release ] fast/webgpu/fuzz-273503.html [ Pass Failure Timeout ]
[ Debug ] fast/webgpu/fuzz-273578.html [ Skip ]
[ Release ] fast/webgpu/fuzz-273578.html [ Pass Failure Timeout ]
[ Debug ] fast/webgpu/fuzz-273585.html [ Skip ]
[ Release ] fast/webgpu/fuzz-273585.html [ Pass Failure Timeout ]

# Imported W3C HTML/DOM ref tests that are failing.
imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-script-N-between-Rs.html [ ImageOnlyFailure ]
Expand Down
Loading

0 comments on commit 1aa9df8

Please sign in to comment.