Skip to content

Commit

Permalink
REGRESSION (263465@main) Crash when scrolling on Twitter.com
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=256098
rdar://108666748

Reviewed by Wenson Hsieh.

263465@main dropped an isEmpty() checks for the languages vector and this
caused an out-of-bounds accesses later on.

* Source/WebKit/GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::initializeGPUProcess):

Canonical link: https://commits.webkit.org/263512@main
  • Loading branch information
cdumez committed Apr 28, 2023
1 parent 3228c83 commit 1b9b42d
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion Source/WebKit/GPUProcess/GPUProcess.cpp
Expand Up @@ -280,7 +280,9 @@ void GPUProcess::initializeGPUProcess(GPUProcessCreationParameters&& parameters)
WTF::Thread::setCurrentThreadIsUserInteractive(0);

WebCore::setPresentingApplicationPID(parameters.parentPID);
overrideUserPreferredLanguages(parameters.overrideLanguages);

if (!parameters.overrideLanguages.isEmpty())
overrideUserPreferredLanguages(parameters.overrideLanguages);

#if USE(OS_STATE)
registerWithStateDumper("GPUProcess state"_s);
Expand Down

0 comments on commit 1b9b42d

Please sign in to comment.