Skip to content

Commit

Permalink
[PGO] Fix build on intel machines
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=239396

Reviewed by Jonathan Bedard.

We should use the correct comparison operator for Perl strings when checking
if we are building with PGO profile generation enabled.

Canonical link: https://commits.webkit.org/249727@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292962 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
webkit-commit-queue committed Apr 18, 2022
1 parent 0ea480c commit 1f0330e
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 1 deletion.
10 changes: 10 additions & 0 deletions ChangeLog
@@ -1,3 +1,13 @@
2022-04-15 Justin Michaud <justin_michaud@apple.com>

[PGO] Fix build on intel machines
https://bugs.webkit.org/show_bug.cgi?id=239396

Reviewed by Jonathan Bedard.

We should use the correct comparison operator for Perl strings when checking
if we are building with PGO profile generation enabled.

2022-04-12 Jonathan Bedard <jbedard@apple.com>

[git-webkit] Allow projects to declare alternate remotes
Expand Down
12 changes: 12 additions & 0 deletions Tools/ChangeLog
@@ -1,3 +1,15 @@
2022-04-15 Justin Michaud <justin_michaud@apple.com>

[PGO] Fix build on intel machines
https://bugs.webkit.org/show_bug.cgi?id=239396

Reviewed by Jonathan Bedard.

We should use the correct comparison operator for Perl strings when checking
if we are building with PGO profile generation enabled.

* Scripts/check-for-weak-vtables-and-externals:

2022-04-18 Elliott Williams <emw@apple.com>

[XCBuild] Use XCBuild for all command-line and project builds
Expand Down
2 changes: 1 addition & 1 deletion Tools/Scripts/check-for-weak-vtables-and-externals
Expand Up @@ -60,7 +60,7 @@ if (!defined $executablePathAge || !defined $buildTimestampAge || $executablePat
}
my @weakVTableClasses = ();
my @weakExternalSymbols = ();
my $skipProfileSymbols = coverageIsEnabled() || $ENV{'ENABLE_LLVM_PROFILE_GENERATION'} == "ON" || $ENV{'ENABLE_LLVM_PROFILE_GENERATION'} == "ENABLE_LLVM_PROFILE_GENERATION";
my $skipProfileSymbols = coverageIsEnabled() || $ENV{'ENABLE_LLVM_PROFILE_GENERATION'} eq "ON" || $ENV{'ENABLE_LLVM_PROFILE_GENERATION'} eq "ENABLE_LLVM_PROFILE_GENERATION";
while (<NM>) {
if (/^STDOUT:/) {
# Ignore undefined, RTTI and typeinfo symbols.
Expand Down

0 comments on commit 1f0330e

Please sign in to comment.