Skip to content

Commit

Permalink
Shrink size of LiteralParserToken from 24 bytes from 16 bytes.
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=256057

Reviewed by Geoffrey Garen.

Shrink size of LiteralParserToken from 24 bytes from 16 bytes, by re-ordering
data members for better bit packing.

* Source/JavaScriptCore/runtime/LiteralParser.h:

Canonical link: https://commits.webkit.org/263477@main
  • Loading branch information
cdumez committed Apr 28, 2023
1 parent 353f4a5 commit 1f5d2a1
Showing 1 changed file with 5 additions and 9 deletions.
14 changes: 5 additions & 9 deletions Source/JavaScriptCore/runtime/LiteralParser.h
Expand Up @@ -74,17 +74,13 @@ WTF_MAKE_NONCOPYABLE(LiteralParserToken);
LiteralParserToken() = default;

TokenType type;
unsigned stringIs8Bit : 1; // Only used for TokString.
unsigned stringOrIdentifierLength : 31;
union {
double numberToken; // Only used for TokNumber.
struct {
union {
const CharType* identifierStart;
const LChar* stringStart8;
const UChar* stringStart16;
};
unsigned stringIs8Bit : 1; // Only used for TokString.
unsigned stringOrIdentifierLength : 31;
};
const CharType* identifierStart;
const LChar* stringStart8;
const UChar* stringStart16;
};
};

Expand Down

0 comments on commit 1f5d2a1

Please sign in to comment.