Skip to content

Commit

Permalink
Cherry-pick 6082b4a. rdar://114412655
Browse files Browse the repository at this point in the history
    Interaction: When using media controls in full screen, Safari thinks we're trying to type.
    https://bugs.webkit.org/show_bug.cgi?id=260754
    rdar://114412655

    Reviewed by Richard Robinson.

    visionOS is popping up the potential phishing alert when you tap
    around in the fullscreen media controls. This platform has a virtual
    keyboard, but it is always in a separate window, so we don't need
    the phishing protection. Turn it off for visionOS.

    I left a FIXME saying it would be better to have this feature
    controlled globally with a USE or HAVE.

    * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
    (-[WKContentView _shouldAvoidSecurityHeuristicScoreUpdates]):

    Canonical link: https://commits.webkit.org/267329@main

Identifier: 265870.466@safari-7616-branch
  • Loading branch information
grorg authored and Dan Robson committed Aug 29, 2023
1 parent f8cff95 commit 1f92940
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
Original file line number Diff line number Diff line change
Expand Up @@ -11736,7 +11736,10 @@ - (void)uninstallImageAnalysisInteraction

- (BOOL)_shouldAvoidSecurityHeuristicScoreUpdates
{
#if ENABLE(IMAGE_ANALYSIS_ENHANCEMENTS)
// FIXME: The whole security heuristic thing should be a USE/HAVE.
#if PLATFORM(VISION)
return YES;
#elif ENABLE(IMAGE_ANALYSIS_ENHANCEMENTS)
return [_imageAnalysisInteraction hasActiveTextSelection];
#else
return NO;
Expand Down

0 comments on commit 1f92940

Please sign in to comment.