Skip to content

Commit

Permalink
KeyHandle should have a virtual destructor
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=274354

Reviewed by Chris Dumez.

Added a virtual destructor since this class has subclasses.

* Source/WebCore/platform/encryptedmedia/CDMProxy.h:
(WebCore::KeyHandle::~KeyHandle):

Canonical link: https://commits.webkit.org/278963@main
  • Loading branch information
rniwa committed May 18, 2024
1 parent 5713584 commit 20328d8
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions Source/WebCore/platform/encryptedmedia/CDMProxy.h
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@ class KeyHandle : public ThreadSafeRefCounted<KeyHandle> {
{
return adoptRef(*new KeyHandle(status, WTFMove(keyID), WTFMove(keyHandleValue)));
}

virtual ~KeyHandle() { }

Ref<SharedBuffer> idAsSharedBuffer() const { return SharedBuffer::create(m_id.span()); }

bool takeValueIfDifferent(KeyHandleValueVariant&&);
Expand Down

0 comments on commit 20328d8

Please sign in to comment.