Skip to content

Commit

Permalink
[WPE][GTK] Switch to 23.08 Flatpak SDK runtime
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=263161

Reviewed by Carlos Alberto Lopez Perez.

* LayoutTests/platform/glib/TestExpectations:
* Tools/Scripts/libraries/webkitflaskpy/webkitflaskpy/__init__.py:
* Tools/flatpak/flatpakutils.py:
(WebkitFlatpak.run_in_sandbox):
(WebkitFlatpak._get_dependency_packages):

Canonical link: https://commits.webkit.org/271043@main
  • Loading branch information
philn committed Nov 22, 2023
1 parent aaa5662 commit 225be87
Show file tree
Hide file tree
Showing 12 changed files with 327 additions and 106 deletions.
84 changes: 83 additions & 1 deletion LayoutTests/platform/glib/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -1106,7 +1106,6 @@ webkit.org/b/146720 media/accessiblity-describes-video.html [ Failure ]
webkit.org/b/227934 media/media-source/media-webm-vorbis-partial.html [ Failure ]
webkit.org/b/265016 media/media-webm-opus-error.html [ Failure ]

webkit.org/b/229973 media/track/in-band/track-in-band-kate-ogg-cues-added-once.html [ Failure Pass ]
webkit.org/b/229973 media/track/in-band/track-in-band-srt-mkv-cues-added-once.html [ Failure Pass ]

# Crashing since https://commits.webkit.org/254142@main
Expand Down Expand Up @@ -1570,6 +1569,39 @@ webkit.org/b/263629 http/tests/multipart/win-boundary-crash.html [ Skip ] # Cras
webkit.org/b/263867 http/tests/multipart/images.html [ ImageOnlyFailure ]
webkit.org/b/263867 http/tests/multipart/multipart-async-image.html [ Failure ]

webkit.org/b/264804 http/tests/cookies/same-site/fetch-after-navigating-iframe-in-cross-origin-page.html [ Failure ]
webkit.org/b/264804 http/tests/cookies/same-site/fetch-in-cross-origin-service-worker.html [ Failure ]
webkit.org/b/264804 http/tests/cookies/same-site/popup-cross-site-post.html [ Failure ]
webkit.org/b/264804 http/tests/cookies/third-party-cookie-relaxing.html [ Failure ]
webkit.org/b/264804 http/tests/resourceLoadStatistics/blocking-in-web-worker-script-import.html [ Failure ]
webkit.org/b/264804 http/tests/resourceLoadStatistics/no-third-party-cookie-blocking-when-itp-is-off.html [ Failure ]
webkit.org/b/264804 http/tests/resourceLoadStatistics/ping-to-prevalent-resource.html [ Failure ]
webkit.org/b/264804 http/tests/resourceLoadStatistics/third-party-cookie-blocking-on-sites-without-user-interaction.html [ Failure ]
webkit.org/b/264804 http/tests/storageAccess/aggregate-sorted-data-with-storage-access.html [ Failure ]
webkit.org/b/264804 http/tests/storageAccess/grant-storage-access-under-opener-at-popup-user-gesture-ephemeral.html [ Failure ]
webkit.org/b/264804 http/tests/storageAccess/grant-storage-access-under-opener-at-popup-user-gesture.html [ Failure ]
webkit.org/b/264804 http/tests/storageAccess/grant-with-prompt-under-general-third-party-cookie-blocking.html [ Failure ]
webkit.org/b/264804 http/tests/storageAccess/has-storage-access-true-if-third-party-has-cookies.html [ Failure ]
webkit.org/b/264804 http/tests/storageAccess/has-storage-access-under-general-third-party-cookie-blocking-with-cookie.html [ Failure ]
webkit.org/b/264804 http/tests/storageAccess/request-and-grant-access-cross-origin-non-sandboxed-iframe-ephemeral.html [ Failure ]
webkit.org/b/264804 http/tests/storageAccess/request-and-grant-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-user-interaction-and-access-from-right-frame.html [ Failure ]
webkit.org/b/264804 http/tests/storageAccess/request-and-grant-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-user-interaction-but-access-from-wrong-frame.html [ Failure ]
webkit.org/b/264804 http/tests/storageAccess/request-and-grant-access-cross-origin-sandboxed-nested-iframe.html [ Failure ]
webkit.org/b/264804 http/tests/storageAccess/request-and-grant-access-then-detach-should-not-have-access.html [ Failure ]
webkit.org/b/264804 http/tests/storageAccess/request-and-grant-access-then-navigate-cross-site-should-not-have-access.html [ Failure ]
webkit.org/b/264804 http/tests/storageAccess/request-and-grant-access-then-navigate-same-site-should-have-access.html [ Failure ]
webkit.org/b/264804 http/tests/storageAccess/request-and-grant-access-with-per-page-scope-access-from-another-frame.html [ Failure ]
webkit.org/b/264804 http/tests/websocket/tests/hybi/websocket-allowed-setting-cookie-as-third-party.html [ Failure ]
webkit.org/b/264804 http/tests/websocket/tests/hybi/websocket-cookie-overwrite-behavior.html [ Failure ]
webkit.org/b/264804 http/tests/xmlhttprequest/cross-origin-authorization.html [ Failure ]
webkit.org/b/264804 http/tests/xmlhttprequest/cross-origin-cookie-storage.html [ Failure ]
webkit.org/b/264804 http/tests/resourceLoadStatistics/operating-dates-all-but-cookies-not-removed-with-user-interaction-6-days-ago.html [ Pass Timeout ]

webkit.org/b/264805 imported/w3c/web-platform-tests/websockets/basic-auth.any.html?wss [ Failure ]
webkit.org/b/264805 imported/w3c/web-platform-tests/websockets/basic-auth.any.serviceworker.html?wss [ Failure ]
webkit.org/b/264805 imported/w3c/web-platform-tests/websockets/basic-auth.any.sharedworker.html?wss [ Failure ]
webkit.org/b/264805 imported/w3c/web-platform-tests/websockets/basic-auth.any.worker.html?wss [ Failure ]

#////////////////////////////////////////////////////////////////////////////////////////
# End of SOUP and Networking-related bugs
#////////////////////////////////////////////////////////////////////////////////////////
Expand Down Expand Up @@ -2668,6 +2700,13 @@ platform/glib/media/media-can-play-dash.html [ Skip ]
imported/w3c/web-platform-tests/cookie-store [ Skip ]
imported/w3c/web-platform-tests/cookies/partitioned-cookies/partitioned-cookies.tentative.https.html [ Skip ]

# As of the 23.08 release of the BuildStream SDK the GStreamer kate plugin is no longer shipped.
media/track/in-band/track-in-band-kate-ogg-addtrack.html [ Skip ]
media/track/in-band/track-in-band-kate-ogg-cues-added-once.html [ Skip ]
media/track/in-band/track-in-band-kate-ogg-kind.html [ Skip ]
media/track/in-band/track-in-band-kate-ogg-language.html [ Skip ]
media/track/in-band/track-in-band-kate-ogg-track-order.html [ Skip ]

#////////////////////////////////////////////////////////////////////////////////////////
# End of UNSUPPORTED tests.
#////////////////////////////////////////////////////////////////////////////////////////
Expand All @@ -2680,6 +2719,49 @@ webkit.org/b/264936 http/wpt/webrtc/transfer-datachannel-service-worker.https.ht

webkit.org/b/264933 fast/mediastream/image-capture-take-photo.html [ Pass Failure Crash ]

webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-abspos-between-003.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-block-between-001.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-block-between-002.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-contains-block-001.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-contains-block-002.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-contains-block-004.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-contains-block-inside-inline-001.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-contains-block-inside-inline-002.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-contains-relpos-block-001.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-contains-relpos-block-002.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-contains-run-in-001.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-contains-run-in-002.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-contains-table-001.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-contains-table-002.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-contains-table-inside-inline-001.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-contains-table-inside-inline-002.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-display-none-between-003.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-fixedpos-between-003.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-float-between-003.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-inline-between-001.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-inline-between-002.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-inline-block-between-001.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-inline-block-between-002.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-inline-table-between-001.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-inline-table-between-002.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-listitem-between-002.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-relpos-between-001.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-relpos-between-002.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-restyle-001.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-restyle-002.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-run-in-between-001.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-run-in-between-002.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-run-in-between-008.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-table-between-001.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-table-between-002.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-table-cell-between-001.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-table-cell-between-002.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-table-row-between-001.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-table-row-between-002.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-text-between-001.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-text-between-002.xht [ ImageOnlyFailure ]
webkit.org/b/264814 imported/w3c/web-platform-tests/css/css-display/run-in/run-in-text-between-003.xht [ ImageOnlyFailure ]

webkit.org/b/264700 security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star.html [ Pass ImageOnlyFailure ]
webkit.org/b/264700 imported/w3c/web-platform-tests/css/compositing/mix-blend-mode/mix-blend-mode-video.html [ Pass ImageOnlyFailure ]
webkit.org/b/264700 imported/w3c/web-platform-tests/css/css-color/filters-under-will-change-opacity.html [ Pass ImageOnlyFailure ]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,13 @@ PASS closeEvent.reason is 'ok'
WebSocketTest.onopen() was called with testId = 3.
WebSocketTest.onclose() was called with testId = 3.
PASS typeof closeEvent.wasClean is 'boolean'
FAIL closeEvent.wasClean should be false. Was true.
FAIL closeEvent.code should be 1006. Was 1005.
FAIL closeEvent.reason should be . Was foo.
PASS closeEvent.wasClean is false
PASS closeEvent.code is 1006
PASS closeEvent.reason is ''
PASS typeof closeEvent.wasClean is 'boolean'
FAIL closeEvent.wasClean should be false. Was true.
FAIL closeEvent.code should be 1006. Was 1005.
FAIL closeEvent.reason should be . Was foo.
PASS closeEvent.wasClean is false
PASS closeEvent.code is 1006
PASS closeEvent.reason is ''
WebSocketTest.onopen() was called with testId = 4.
WebSocketTest.onclose() was called with testId = 4.
PASS typeof closeEvent.wasClean is 'boolean'
Expand All @@ -69,13 +69,13 @@ PASS closeEvent.reason is ''
WebSocketTest.onopen() was called with testId = 6.
WebSocketTest.onclose() was called with testId = 6.
PASS typeof closeEvent.wasClean is 'boolean'
PASS closeEvent.wasClean is true
PASS closeEvent.code is 65535
PASS closeEvent.reason is 'good bye'
FAIL closeEvent.wasClean should be true. Was false.
FAIL closeEvent.code should be 65535. Was 1006.
FAIL closeEvent.reason should be good bye. Was .
PASS typeof closeEvent.wasClean is 'boolean'
PASS closeEvent.wasClean is true
PASS closeEvent.code is 65535
PASS closeEvent.reason is 'good bye'
FAIL closeEvent.wasClean should be true. Was false.
FAIL closeEvent.code should be 65535. Was 1006.
FAIL closeEvent.reason should be good bye. Was .
PASS successfullyParsed is true

TEST COMPLETE
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@ PASS PASS: worker: event.code is 1000
PASS PASS: worker: event.reason is ok
WebSocketTest.onopen() was called with testId = 3.
WebSocketTest.onclose() was called with testId = 3.
FAIL FAIL: worker: event.wasClean is not false
FAIL FAIL: worker: event.code is not 1006
FAIL FAIL: worker: event.reason is not
FAIL FAIL: worker: event.wasClean is not false
FAIL FAIL: worker: event.code is not 1006
FAIL FAIL: worker: event.reason is not
PASS PASS: worker: event.wasClean is false
PASS PASS: worker: event.code is 1006
PASS PASS: worker: event.reason is
PASS PASS: worker: event.wasClean is false
PASS PASS: worker: event.code is 1006
PASS PASS: worker: event.reason is
WebSocketTest.onopen() was called with testId = 4.
WebSocketTest.onclose() was called with testId = 4.
PASS PASS: worker: event.wasClean is false
Expand All @@ -56,12 +56,12 @@ PASS PASS: worker: event.code is 1006
PASS PASS: worker: event.reason is
WebSocketTest.onopen() was called with testId = 6.
WebSocketTest.onclose() was called with testId = 6.
PASS PASS: worker: event.wasClean is true
PASS PASS: worker: event.code is 65535
PASS PASS: worker: event.reason is good bye
PASS PASS: worker: event.wasClean is true
PASS PASS: worker: event.code is 65535
PASS PASS: worker: event.reason is good bye
FAIL FAIL: worker: event.wasClean is not true
FAIL FAIL: worker: event.code is not 65535
FAIL FAIL: worker: event.reason is not good bye
FAIL FAIL: worker: event.wasClean is not true
FAIL FAIL: worker: event.code is not 65535
FAIL FAIL: worker: event.reason is not good bye
DONE
PASS successfullyParsed is true

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,116 @@
AccName: Host Language Label Tests

Tests the #comp_host_language_label portions of the AccName Name Computation algorithm.

HTML input with value, alt, etc.


HTML input label/for

checkbox label
color label
date label
datetime-local label
email label
month label
number label
password label
radio label
range label
search label
tel label
textfield label
time label
url label
week label
HTML input label encapsulation

checkbox label
color label
date label
datetime-local label
email label
month label
number label
password label
radio label
range label
search label
tel label
textfield label
time label
url label
week label
HTML select

select label
select label
HTML img/picture


HTML fieldset/legend

fieldset legend label

HTML table/caption

table caption label
a b c
1 2 3
SVG title




PASS html: input[type=button]
PASS html: input[type=image]
PASS html: input[type=reset]
PASS html: input[type=submit]
PASS html: label[for] input[type=checkbox]
PASS html: label[for] input[type=color]
PASS html: label[for] input[type=date]
PASS html: label[for] input[type=datetime-local]
PASS html: label[for] input[type=email]
PASS html: label[for] input[type=month]
PASS html: label[for] input[type=number]
PASS html: label[for] input[type=password]
PASS html: label[for] input[type=radio]
PASS html: label[for] input[type=range]
PASS html: label[for] input[type=search]
PASS html: label[for] input[type=tel]
PASS html: label[for] input[type=text]
PASS html: label[for] input[type=time]
PASS html: label[for] input[type=url]
PASS html: label[for] input[type=week]
PASS html: label input[type=checkbox] encapsulation
PASS html: label input[type=color] encapsulation
FAIL html: label input[type=date] encapsulation assert_equals: <input type="date" data-expectedlabel="date label" data-testname="html: label input[type=date] encapsulation" class="ex"> expected "date label" but got "month / day / year date label"
FAIL html: label input[type=datetime-local] encapsulation assert_equals: <input type="datetime-local" data-expectedlabel="datetime-local label" data-testname="html: label input[type=datetime-local] encapsulation" class="ex"> expected "datetime-local label" but got "month / day / year , 12 : 30   PM datetime-local label"
PASS html: label input[type=email] encapsulation
FAIL html: label input[type=month] encapsulation assert_equals: <input type="month" data-expectedlabel="month label" data-testname="html: label input[type=month] encapsulation" class="ex"> expected "month label" but got "month year month label"
PASS html: label input[type=number] encapsulation
PASS html: label input[type=password] encapsulation
PASS html: label input[type=radio] encapsulation
FAIL html: label input[type=range] encapsulation assert_equals: <input type="range" data-expectedlabel="range label" data-testname="html: label input[type=range] encapsulation" class="ex"> expected "range label" but got "50 range label"
FAIL html: label input[type=search] encapsulation assert_equals: <input type="search" data-expectedlabel="search label" data-testname="html: label input[type=search] encapsulation" class="ex"> expected "search label" but got "cancel search label"
PASS html: label input[type=tel] encapsulation
PASS html: label[for] input[type=text] encapsulation
FAIL html: label input[type=time] encapsulation assert_equals: <input type="time" data-expectedlabel="time label" data-testname="html: label input[type=time] encapsulation" class="ex"> expected "time label" but got "12 : 30   PM time label"
PASS html: label input[type=url] encapsulation
PASS html: label input[type=week] encapsulation
PASS html: select for/id
FAIL html: select encapsulation assert_equals: <select data-expectedlabel="select label" data-testname="html: select encapsulation" class="ex">
<option>foo</option>
</select> expected "select label" but got "select label foo"
PASS html: img[alt] (non-empty)
PASS html: picture > img[alt] (non-empty)
FAIL html: fieldset > legend assert_equals: <fieldset data-expectedlabel="fieldset legend label" data-testname="html: fieldset > legend" class="ex">
<legend>fieldset legend label</legend>
<input type="text"><br>
</fieldset> expected "fieldset legend label" but got ""
PASS html: table > caption
PASS svg: circle > title
PASS svg: rect > title
PASS svg: polygon > title
PASS svg: g > title

Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ PASS No cookie returned for partial path match
PASS No cookie returned for partial path match, return cookie for default path
PASS Return cookie for path= / (whitespace after equals)
PASS No cookie returned for case mismatched path
FAIL Return cookie A on path match, no cookie returned for path mismatch (plus whitespace) assert_equals: The cookie was set as expected. expected "testA=19" but got ""
PASS Return cookie A on path match, no cookie returned for path mismatch (plus whitespace)
PASS No cookie returned for mismatched path (after bare path=)
FAIL Return cookie for bare path= (after mismatched path) assert_equals: The cookie was set as expected. expected "test=21" but got "testA=19; testB=19; test=21"
PASS Return cookie for bare path= (after mismatched path)

Loading

0 comments on commit 225be87

Please sign in to comment.