-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Cherry-pick b8f448e. rdar://122663646
[IFC][Ruby] Failure to line break before/between ruby sequences https://bugs.webkit.org/show_bug.cgi?id=271209 <rdar://122663646> Reviewed by Antti Koivisto. Not all "do not break before" characters have "do not break after" meaning. (e.g. no line should begin with KATAKANA MIDDLE DOT but it's ok to have it at the end of the line). Let's divide them into 2 categories as seen in https://www.w3.org/TR/jlreq. *LayoutTests/fast/ruby/ruby-with-unbreakable-characters-incorrect-width.html: use different punctuation to force line breaking at the right position. * LayoutTests/fast/ruby/can-break-before-after-expected.html: Added. * LayoutTests/fast/ruby/can-break-before-after.html: Added. * Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp: (WebCore::Layout::canBreakBefore): (WebCore::Layout::canBreakAfter): (WebCore::Layout::RubyFormattingContext::isAtSoftWrapOpportunity): (WebCore::Layout::canBreakAtCharacter): Deleted. Canonical link: https://commits.webkit.org/276353@main Identifier: 272448.821@safari-7618-branch
- Loading branch information
1 parent
f3567ff
commit 2368888
Showing
4 changed files
with
55 additions
and
5 deletions.
There are no files selected for viewing
12 changes: 12 additions & 0 deletions
12
LayoutTests/fast/ruby/can-break-before-after-expected.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
<meta charset="utf8"> | ||
<style> | ||
div { | ||
font-family: Ahem; | ||
text-align-last: justify; | ||
font-size: 20px; | ||
width: 380px; | ||
} | ||
</style> | ||
<div>X X X X ・<ruby>b a s e</ruby>・</div> | ||
<div><ruby>b a s e</ruby></div> | ||
<pre>PASS if ・ is not at the start of 'base...' line</pre> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
<meta charset="utf8"> | ||
<style> | ||
div { | ||
font-family: Ahem; | ||
text-align: justify; | ||
font-size: 20px; | ||
width: 380px; | ||
} | ||
</style> | ||
<div>X X X X ・<ruby>b a s e</ruby>・<ruby>b a s e</ruby></div> | ||
<pre>PASS if ・ is not at the start of 'base...' line</pre> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters