Skip to content

Commit

Permalink
Import field-sizing WPT tests
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=268954

Reviewed by Aditya Keerthi.

Imports CSS parsing and HTML rendering tests for the field-sizing CSS property

Upstream commit: web-platform-tests/wpt@3c00d74

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/field-sizing-computed-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/field-sizing-computed.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/field-sizing-invalid-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/field-sizing-invalid.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/field-sizing-valid-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/field-sizing-valid.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-number-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-number.tentative-expected.txt.
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-number.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-number.tentative.html.
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text.tentative-expected.txt.
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text.tentative.html.
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select.tentative-expected.txt.
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select.tentative.html.
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea.tentative-expected.txt.
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea.tentative.html.
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/w3c-import.log:
* LayoutTests/platform/glib/TestExpectations:

Canonical link: https://commits.webkit.org/274299@main
  • Loading branch information
lukewarlow committed Feb 8, 2024
1 parent 829ee3d commit 24a12aa
Show file tree
Hide file tree
Showing 18 changed files with 75 additions and 8 deletions.
8 changes: 6 additions & 2 deletions LayoutTests/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -831,8 +831,6 @@ imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/the-page/bo
imported/w3c/web-platform-tests/html/rendering/replaced-elements/embedded-content/change-src-while-not-displayed.html [ ImageOnlyFailure Pass ]
imported/w3c/web-platform-tests/html/rendering/replaced-elements/images/input-image-content.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/html/rendering/replaced-elements/the-select-element/select-empty.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-number.tentative.html [ Failure ]
imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text.tentative.html [ Failure ]
imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/anonymous-button-content-box.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/inline-level.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/propagate-text-decoration.html [ ImageOnlyFailure ]
Expand Down Expand Up @@ -1061,6 +1059,12 @@ imported/w3c/web-platform-tests/css/css-ui/caret-color-020.html [ Skip ]
# Dump console messages to stderr for all the imported Content Security Policy tests to avoid flakiness.
imported/w3c/web-platform-tests/content-security-policy [ DumpJSConsoleLogInStdErr ]

# field-sizing is not supported
imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-number.html [ Skip ]
imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text.html [ Skip ]
imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select.html [ Skip ]
imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea.html [ Skip ]

# FIXME: Skip Content Security Policy tests that are dumping the render tree instead of text:
imported/w3c/web-platform-tests/content-security-policy/svg/scripted.svg [ Skip ]
imported/w3c/web-platform-tests/content-security-policy/svg/including.sub.svg [ Skip ]
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@

FAIL Property field-sizing value 'fixed' assert_true: field-sizing doesn't seem to be supported in the computed style expected true got false
FAIL Property field-sizing value 'content' assert_true: field-sizing doesn't seem to be supported in the computed style expected true got false

Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<!DOCTYPE html>
<title>CSS UI: getComputedStyle().fieldSizing</title>
<link rel="help" href="https://drafts.csswg.org/css-ui-4/#field-sizing">
<link rel="author" title="Kent Tamura" href="mailto:tkent@chromium.org">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/css/support/computed-testcommon.js"></script>
<body>
<div id="target"></div>
<script>
test_computed_value('field-sizing', 'fixed');
test_computed_value('field-sizing', 'content');
</script>
</body>
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@

PASS e.style['field-sizing'] = "none" should not set the property value
PASS e.style['field-sizing'] = "legacy" should not set the property value
PASS e.style['field-sizing'] = "auto" should not set the property value
PASS e.style['field-sizing'] = "normal" should not set the property value
PASS e.style['field-sizing'] = "normal auto" should not set the property value
PASS e.style['field-sizing'] = "100%" should not set the property value
PASS e.style['field-sizing'] = "10px" should not set the property value

Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<!DOCTYPE html>
<title>CSS UI: parsing field-sizing with invalid values</title>
<link rel="help" href="https://drafts.csswg.org/css-ui-4/#field-sizing">
<link rel="author" title="Kent Tamura" href="mailto:tkent@chromium.org">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/css/support/parsing-testcommon.js"></script>
<body>
<script>
test_invalid_value('field-sizing', 'none');
test_invalid_value('field-sizing', 'legacy');
test_invalid_value('field-sizing', 'auto');
test_invalid_value('field-sizing', 'normal');
test_invalid_value('field-sizing', 'normal auto');
test_invalid_value('field-sizing', '100%');
test_invalid_value('field-sizing', '10px');
</script>
</body>
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@

FAIL e.style['field-sizing'] = "fixed" should set the property value assert_not_equals: property should be set got disallowed value ""
FAIL e.style['field-sizing'] = "content" should set the property value assert_not_equals: property should be set got disallowed value ""

Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<!DOCTYPE html>
<title>CSS UI: parsing field-sizing with valid values</title>
<link rel="help" href="https://drafts.csswg.org/css-ui-4/#field-sizing">
<link rel="author" title="Kent Tamura" href="mailto:tkent@chromium.org">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/css/support/parsing-testcommon.js"></script>
<body>
<script>
test_valid_value('field-sizing', 'fixed');
test_valid_value('field-sizing', 'content');
</script>
</body>
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ List of files:
/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/cursor-computed.html
/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/cursor-invalid.html
/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/cursor-valid.html
/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/field-sizing-computed.html
/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/field-sizing-invalid.html
/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/field-sizing-valid.html
/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/outline-color-computed.html
/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/outline-color-invalid.html
/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/parsing/outline-color-valid-mandatory.html
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ None
------------------------------------------------------------------------
List of files:
/LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/baseline-alignment-and-overflow.tentative.html
/LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-number.tentative.html
/LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text.tentative.html
/LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select.tentative.html
/LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea.tentative.html
/LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-number.html
/LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-input-text.html
/LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select.html
/LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea.html
/LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/input-checkbox-disabled-checked-expected-mismatch.html
/LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/input-checkbox-disabled-checked-notref.html
/LayoutTests/imported/w3c/web-platform-tests/html/rendering/widgets/input-checkbox-disabled-checked.html
Expand Down
2 changes: 0 additions & 2 deletions LayoutTests/platform/glib/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -222,8 +222,6 @@ imported/w3c/web-platform-tests/html/rendering/the-details-element/details-befor
imported/w3c/web-platform-tests/html/rendering/widgets/input-checkbox-disabled-checked.html [ Pass ]
imported/w3c/web-platform-tests/html/rendering/widgets/input-radio-disabled-checked.html [ Pass ]
imported/w3c/web-platform-tests/html/rendering/widgets/input-checkbox-switch-rtl.tentative.html [ Failure ]
imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-select.tentative.html [ Failure ]
imported/w3c/web-platform-tests/html/rendering/widgets/field-sizing-textarea.tentative.html [ Failure ]
imported/w3c/web-platform-tests/html/rendering/widgets/the-select-element/select-as-listbox-default-styles.tentative.html [ Failure ]

imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/link-rel-attribute-ascii-case-insensitive.html [ Pass ]
Expand Down

0 comments on commit 24a12aa

Please sign in to comment.