Skip to content

Commit

Permalink
REGRESSION (270339@main): [ iOS17 ] TestWebKitAPI.WebKit.InvalidConfi…
Browse files Browse the repository at this point in the history
…guration is a crash failure

https://bugs.webkit.org/show_bug.cgi?id=264609
rdar://118242512

Reviewed by Alex Christensen.

* Source/WebKit/UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm:
(-[WKWebViewContentProviderRegistry initWithConfiguration:]):
ObjC null rules stop applying when you start using C++ ivars.

Canonical link: https://commits.webkit.org/270603@main
  • Loading branch information
hortont424 committed Nov 11, 2023
1 parent 741ed20 commit 29d1f69
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ - (instancetype)initWithConfiguration:(WKWebViewConfiguration *)configuration
return nil;

#if ENABLE(WKPDFVIEW)
if (!configuration.preferences->_preferences->unifiedPDFEnabled()) {
if (!configuration.preferences || !configuration.preferences->_preferences->unifiedPDFEnabled()) {
for (auto& type : WebCore::MIMETypeRegistry::pdfMIMETypes())
[self registerProvider:[WKPDFView class] forMIMEType:@(type.characters())];
}
Expand Down

0 comments on commit 29d1f69

Please sign in to comment.