Skip to content

Commit

Permalink
Remove duplicate 'svg/animations' tests in favor of WPT
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=266957

Reviewed by Tim Nguyen.

In 272547@main, I did WPT sync from upstream and then compared the directories of
`svg/animations` and WPT directory and found these duplicates. This PR is to remove
local copies of tests in favor of upstream WPT and also update 'Test Expectations' accordingly.

* LayoutTests/svg/animations/: Delete multiple tests
* LayoutTests/platform/glib/TestExpectations: Clean-up to remove deleted tests
* LayoutTests/platform/gtk/TestExpectations: Ditto
* LayoutTests/platform/ios-wk2/TestExpectations: Ditto
* LayoutTests/platform/ios/TestExpectations: Ditto
* LayoutTests/platform/mac-wk1/TestExpectations: Ditto
* LayoutTests/platform/mac-wk2/TestExpectations: Ditto
* LayoutTests/platform/mac/TestExpectations: Ditto
* LayoutTests/platform/wpe/TestExpectations: Ditto
* LayoutTests/TestExpectations: Ditto

Canonical link: https://commits.webkit.org/272558@main
  • Loading branch information
Ahmad-S792 authored and Ahmad Saleem committed Jan 1, 2024
1 parent c0e3ff4 commit 2a92632
Show file tree
Hide file tree
Showing 251 changed files with 0 additions and 13,817 deletions.
3 changes: 0 additions & 3 deletions LayoutTests/TestExpectations
Expand Up @@ -2248,9 +2248,6 @@ http/tests/contentextensions [ Skip ]
http/tests/inspector/network/contentextensions [ Skip ]
http/tests/websocket/tests/hybi/contentextensions [ Skip ]
http/wpt/beacon/contentextensions [ Skip ]

webkit.org/b/149072 svg/animations/svgboolean-animation-1.html [ Pass Failure ]

webkit.org/b/143085 media/track/track-mode.html [ Pass Timeout ]

# In ES6, Object type restrictions on a first parameter of several Object.* functions are relaxed.
Expand Down
1 change: 0 additions & 1 deletion LayoutTests/platform/glib/TestExpectations
Expand Up @@ -1655,7 +1655,6 @@ webkit.org/b/129958 svg/clip-path/mask-objectboundingbox-content-clip.svg [ Imag
webkit.org/b/129958 svg/clip-path/mask-userspaceonuse-content-clip-transform.svg [ ImageOnlyFailure ]
webkit.org/b/129958 svg/clip-path/mask-userspaceonuse-content-clip.svg [ ImageOnlyFailure ]

webkit.org/b/135529 svg/animations/animate-css-xml-attributeType.html [ Failure ]
webkit.org/b/135529 svg/css/parse-height.html [ Failure ]
webkit.org/b/135529 svg/css/parse-length.html [ Failure ]

Expand Down
2 changes: 0 additions & 2 deletions LayoutTests/platform/gtk/TestExpectations
Expand Up @@ -1312,8 +1312,6 @@ webkit.org/b/207605 [ Debug ] http/tests/websocket/tests/hybi/no-subprotocol.htm
# 4. FLAKY TESTS
#////////////////////////////////////////////////////////////////////////////////////////

webkit.org/b/122481 svg/animations/svglengthlist-animation-3.html [ Failure Pass ]

webkit.org/b/89650 [ Debug ] svg/W3C-SVG-1.1/animate-elem-05-t.svg [ Failure Pass ]
webkit.org/b/89650 [ Debug ] svg/W3C-SVG-1.1/animate-elem-06-t.svg [ Failure Pass ]
webkit.org/b/89650 [ Debug ] svg/W3C-SVG-1.1/animate-elem-08-t.svg [ Failure Pass ]
Expand Down
84 changes: 0 additions & 84 deletions LayoutTests/platform/ios-wk2/TestExpectations
Expand Up @@ -194,31 +194,10 @@ svg/transforms/transform-origin-and-box-getCTM.html [ Failure ]
svg/transforms/translation-tiny-element.svg [ ImageOnlyFailure ]

# SVG tests that time out (these require EventSender)
svg/animations/animVal-basics.html
svg/animations/animate-calcMode-spline-by.html
svg/animations/animate-calcMode-spline-from-by.html
svg/animations/animate-calcMode-spline-from-to.html
svg/animations/animate-calcMode-spline-to.html
svg/animations/animate-calcMode-spline-values.html
svg/animations/animate-color-calcMode-discrete.html
svg/animations/animate-color-fill-currentColor.html
svg/animations/animate-color-fill-from-by.html
svg/animations/animate-color-rgba-calcMode-discrete.html
svg/animations/animate-color-transparent.html
svg/animations/animate-currentColor.html
svg/animations/animate-dynamic-update-attributeName.html
svg/animations/animate-end-attribute.html
svg/animations/animate-endElement-beginElement.html
svg/animations/animate-from-to-keyTimes.html
svg/animations/animate-gradient-transform.html
svg/animations/animate-inherit-css-property.html
svg/animations/animate-keySplines.html
svg/animations/animate-marker-orient-from-angle-to-angle.html
svg/animations/animate-marker-orient-from-angle-to-auto.html
svg/animations/animate-marker-orient-to-angle.html
svg/animations/animate-mpath-insert.html
svg/animations/animate-number-calcMode-discrete-keyTimes.html
svg/animations/animate-number-calcMode-discrete.html
svg/animations/animate-path-animation-Cc-Ss.html
svg/animations/animate-path-animation-Ll-Vv-Hh.html
svg/animations/animate-path-animation-Qq-Tt.html
Expand All @@ -228,74 +207,13 @@ svg/animations/animate-path-animation-qQ-tT-inverse.html
svg/animations/animate-path-nested-transforms.html
svg/animations/animate-path-to-animation.html
svg/animations/animate-text-nested-transforms.html
svg/animations/animateTransform-pattern-transform.html
svg/animations/animateTransform-translate-attributetype-auto.html
svg/animations/animateTransform-translate-invalid-attributetype.html
svg/animations/deferred-insertion.html
svg/animations/svgPreserveAspectRatio-animation-1.html
svg/animations/svgangle-animation-deg-to-grad.html
svg/animations/svgangle-animation-deg-to-rad.html
svg/animations/svgangle-animation-grad-to-deg.html
svg/animations/svgangle-animation-grad-to-rad.html
svg/animations/svgangle-animation-rad-to-deg.html
svg/animations/svgangle-animation-rad-to-grad.html
svg/animations/svgboolean-animation-1.html
svg/animations/svgenum-animation-1.html
svg/animations/svgenum-animation-10.html
svg/animations/svgenum-animation-11.html
svg/animations/svgenum-animation-12.html
svg/animations/svgenum-animation-13.html
svg/animations/svgenum-animation-2.html
svg/animations/svgenum-animation-3.html
svg/animations/svgenum-animation-4.html
svg/animations/svgenum-animation-5.html
svg/animations/svgenum-animation-6.html
svg/animations/svgenum-animation-7.html
svg/animations/svgenum-animation-8.html
svg/animations/svgenum-animation-9.html
svg/animations/svginteger-animation-1.html
svg/animations/svginteger-animation-2.html
svg/animations/svglength-animation-LengthModeHeight.html
svg/animations/svglength-animation-LengthModeOther.html
svg/animations/svglength-animation-LengthModeWidth.html
svg/animations/svglength-animation-invalid-value-1.html
svg/animations/svglength-animation-invalid-value-2.html
svg/animations/svglength-animation-invalid-value-3.html
svg/animations/svglength-animation-number-to-number.html
svg/animations/svglength-animation-px-to-cm.html
svg/animations/svglength-animation-px-to-ems.html
svg/animations/svglength-animation-px-to-exs.html
svg/animations/svglength-animation-px-to-in.html
svg/animations/svglength-animation-px-to-number.html
svg/animations/svglength-animation-px-to-pc.html
svg/animations/svglength-animation-px-to-percentage.html
svg/animations/svglength-animation-px-to-pt.html
svg/animations/svglength-animation-px-to-px.html
svg/animations/svglength-animation-unitType.html
svg/animations/svglength-animation-values.html
svg/animations/svglengthlist-animation-1.html
svg/animations/svglengthlist-animation-2.html
svg/animations/svglengthlist-animation-3.html
svg/animations/svglengthlist-animation-4.html
svg/animations/svglengthlist-animation-5.html
svg/animations/svgnumber-animation-1.html
svg/animations/svgnumber-animation-2.html
svg/animations/svgnumber-animation-3.html
svg/animations/svgnumber-animation-4.html
svg/animations/svgnumberlist-animation-1.html
svg/animations/svgnumberlist-animation-2.html
svg/animations/svgnumberoptionalnumber-animation-1.html
svg/animations/svgnumberoptionalnumber-animation-2.html
svg/animations/svgnumberoptionalnumber-animation-3.html
svg/animations/svgnumberoptionalnumber-animation-4.html
svg/animations/svgpath-animation-1.html
svg/animations/svgpointlist-animation-1.html
svg/animations/svgpointlist-animation-2.html
svg/animations/svgrect-animation-1.html
svg/animations/svgrect-animation-2.html
svg/animations/svgstring-animation-fallback-to-discrete.html
svg/animations/svgtransform-animation-1.html
svg/animations/svgtransform-animation-discrete.html
svg/animations/use-animate-transform-and-position.html
svg/animations/use-animate-width-and-height.html [ Skip ]
svg/custom/gradient-attr-update.svg
Expand Down Expand Up @@ -1264,8 +1182,6 @@ webkit.org/b/184783 compositing/ios/overflow-scroll-touch-tiles.html [ Pass Fail

webkit.org/b/179853 [ Debug ] imported/blink/fast/text/international-iteration-simple-text.html [ Pass Failure ]

webkit.org/b/189087 svg/animations/animate-end-attribute-numeric-precision.html [ Pass Failure ]

webkit.org/b/190847 [ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/unregister-then-register-new-script.https.html [ Pass Failure ]

webkit.org/b/190848 imported/w3c/web-platform-tests/service-workers/service-worker/navigation-redirect-to-http.https.html [ Pass Failure ]
Expand Down
3 changes: 0 additions & 3 deletions LayoutTests/platform/ios/TestExpectations
Expand Up @@ -835,7 +835,6 @@ perf/mouse-event.html [ Skip ]
platform/ios/ios/fast/coordinates/mouse-event-zoomed.html [ Skip ]
platform/ios/ios/fast/coordinates/mouse-event.html [ Skip ]
scrollbars/scrollbar-miss-mousemove-disabled.html [ Skip ]
svg/animations/animate-css-xml-attributeType.html [ Skip ]
svg/custom/anchor-on-use.svg [ Skip ]
svg/custom/foreignObject-crash-on-hover.xml [ Skip ]
svg/custom/getscreenctm-in-scrollable-div-area-nested.xhtml [ Skip ]
Expand Down Expand Up @@ -2524,8 +2523,6 @@ fast/events/page-visibility-iframe-move-test.html [ Skip ]

webkit.org/b/161143 imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-samedoc.html [ Pass Failure ]

webkit.org/b/161395 svg/animations/reinserting-svg-into-document.html [ Pass Failure ]

# rdar://problem/26478053
http/tests/dom/document-contentType.html [ Failure ]

Expand Down
2 changes: 0 additions & 2 deletions LayoutTests/platform/mac-wk1/TestExpectations
Expand Up @@ -1812,8 +1812,6 @@ displaylists/layer-dispay-list.html [ Failure ]

webkit.org/b/184611 compositing/layer-creation/fixed-overlap-extent.html [ Pass Failure ]

webkit.org/b/189087 svg/animations/animate-end-attribute-numeric-precision.html [ Pass Failure ]

webkit.org/b/189594 imported/w3c/web-platform-tests/css/css-animations/pending-style-changes-001.html [ Pass Failure ]

webkit.org/b/189756 compositing/filters/opacity-change-on-filtered-paints-into-ancestor.html [ Pass ImageOnlyFailure ]
Expand Down
2 changes: 0 additions & 2 deletions LayoutTests/platform/mac-wk2/TestExpectations
Expand Up @@ -1180,8 +1180,6 @@ webkit.org/b/230105 [ Monterey+ Debug arm64 ] imported/w3c/web-platform-tests/ht

webkit.org/b/230691 [ Release ] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/iframe-popup-unsafe-none-to-unsafe-none.https.html [ Pass Failure ]

webkit.org/b/230113 [ Monterey+ Debug arm64 ] svg/animations/animate-elem-14-t-drt.html [ Pass Crash ]

# rdar://66806059 (REGRESSION (20A2321a-20A2348b): 4 fast hidpi tests are a flaky image failure)
[ arm64 ] fast/flexbox/hidpi-simple-line-layout-with-flexbox-and-transition.html [ ImageOnlyFailure ]
[ arm64 ] fast/inline-block/hidpi-margin-top-with-subpixel-value-and-overflow-hidden.html [ ImageOnlyFailure ]
Expand Down
6 changes: 0 additions & 6 deletions LayoutTests/platform/mac/TestExpectations
Expand Up @@ -223,8 +223,6 @@ media/track/track-webvtt-snap-to-lines-inline-style.html [ Pass Crash ]
# Perf tests are very flaky, because they run in parallel with other tests.
perf

webkit.org/b/113599 svg/animations/reinserting-svg-into-document.html [ Pass Failure ]

webkit.org/b/184608 [ Debug ] animations/added-while-suspended.html [ Skip ]
webkit.org/b/184608 [ Debug ] transitions/created-while-suspended.html [ Skip ]

Expand Down Expand Up @@ -495,8 +493,6 @@ webkit.org/b/114375 svg/batik/filters/feTile.svg [ Pass Failure ]

webkit.org/b/99893 svg/animations/mozilla/animateMotion-mpath-targetChange-1.svg [ ImageOnlyFailure ]

webkit.org/b/98718 svg/animations/animate-css-xml-attributeType.html [ Failure Pass ]

# IETC flexbox failures
webkit.org/b/85211 ietestcenter/css3/flexbox/flexbox-align-stretch-001.htm [ ImageOnlyFailure ]
webkit.org/b/85212 ietestcenter/css3/flexbox/flexbox-layout-002.htm [ ImageOnlyFailure ]
Expand Down Expand Up @@ -566,8 +562,6 @@ webkit.org/b/112176 fast/css/sticky/sticky-both-sides.html [ ImageOnlyFailure Pa
# WebKit1-only
webkit.org/b/103857 fast/events/mouse-cursor-change.html [ Failure ]

webkit.org/b/120387 svg/animations/svglengthlist-animation-3.html [ Pass Failure ]

webkit.org/b/120923 animations/cross-fade-background-image.html [ ImageOnlyFailure ]

webkit.org/b/131244 svg/as-image/svg-as-image-canvas.html [ Pass ImageOnlyFailure ]
Expand Down
2 changes: 0 additions & 2 deletions LayoutTests/platform/wpe/TestExpectations
Expand Up @@ -842,8 +842,6 @@ webkit.org/b/129758 js/dom/create-lots-of-workers.html [ Timeout Pass ]

webkit.org/b/177530 imported/w3c/web-platform-tests/xhr/setrequestheader-header-allowed.htm [ Pass Failure ]

webkit.org/b/179898 svg/animations/svglengthlist-animation-3.html [ Pass Failure ]

webkit.org/b/181534 perf/show-hide-table-rows.html [ Pass Failure ]

webkit.org/b/187590 imported/w3c/web-platform-tests/web-animations/timing-model/timelines/document-timelines.html [ Failure Pass ]
Expand Down

This file was deleted.

104 changes: 0 additions & 104 deletions LayoutTests/svg/animations/accumulate-values-width-animation.html

This file was deleted.

This file was deleted.

0 comments on commit 2a92632

Please sign in to comment.