Skip to content

Commit

Permalink
[JSC] Stop ignoring useWebAssembly=1 when JIT is disabled
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=263763

Reviewed by Justin Michaud.

It's true that WebAssembly won't yet *run* sensibly with JIT off,
but ENABLE(WEBASSEMBLY) && !ENABLE(JIT) *is* a valid build configuration now,
so JSC should permit enabling useWebAssembly even when JIT is disabled.

* Source/JavaScriptCore/runtime/Options.cpp:
(JSC::disableAllJITOptions):

Canonical link: https://commits.webkit.org/270100@main
  • Loading branch information
rkirsling committed Nov 2, 2023
1 parent 868fdd2 commit 2c0494f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Source/JavaScriptCore/runtime/Options.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -617,10 +617,10 @@ static inline void disableAllJITOptions()
Options::useJITCage() = false;
Options::useConcurrentJIT() = false;

Options::useWebAssembly() = false;
if (!OptionsHelper::wasOverridden(Options::useWebAssemblyID))
Options::useWebAssembly() = false;

Options::usePollingTraps() = true;
Options::useLLInt() = true;

Options::dumpDisassembly() = false;
Options::asyncDisassembly() = false;
Expand Down

0 comments on commit 2c0494f

Please sign in to comment.