Skip to content

Commit

Permalink
https://bugs.webkit.org/show_bug.cgi?id=75296
Browse files Browse the repository at this point in the history
JSString should not have JS_EXPORTCLASS annotation

Patch by Hajime Morrita <morrita@chromium.org> on 2012-01-06
Reviewed by Kevin Ollivier.

* runtime/JSString.h: Removed JS_EXPORTCLASS annotation.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Added missing symbols which were hidden by JS_EXPORTCLASS.

Canonical link: https://commits.webkit.org/92564@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104359 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
omo authored and webkit-commit-queue committed Jan 7, 2012
1 parent 354c5cc commit 2ce8293
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 1 deletion.
11 changes: 11 additions & 0 deletions Source/JavaScriptCore/ChangeLog
@@ -1,3 +1,14 @@
2012-01-06 Hajime Morrita <morrita@chromium.org>

https://bugs.webkit.org/show_bug.cgi?id=75296
JSString should not have JS_EXPORTCLASS annotation

Reviewed by Kevin Ollivier.

* runtime/JSString.h: Removed JS_EXPORTCLASS annotation.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Added missing symbols which were hidden by JS_EXPORTCLASS.

2012-01-06 Michael Saboff <msaboff@apple.com>

JSArray::pop() should compare SparseArrayValueMap::find() to SparseArrayValueMap::notFound()
Expand Down
Expand Up @@ -296,6 +296,7 @@ EXPORTS
?retrieveLastCaller@Interpreter@JSC@@QBEXPAVExecState@2@AAH1AAVUString@2@AAVJSValue@2@@Z
?s_globalObjectMethodTable@JSGlobalObject@JSC@@1UGlobalObjectMethodTable@2@B
?s_info@ExecutableBase@JSC@@2UClassInfo@2@B
?s_info@JSString@JSC@@2UClassInfo@2@B
?setConfigurable@PropertyDescriptor@JSC@@QAEX_N@Z
?setDescriptor@PropertyDescriptor@JSC@@QAEXVJSValue@2@I@Z
?setDumpsGeneratedCode@BytecodeGenerator@JSC@@SAX_N@Z
Expand Down Expand Up @@ -336,6 +337,7 @@ EXPORTS
?timedWait@ThreadCondition@WTF@@QAE_NAAVMutex@2@N@Z
?tlsKeyCount@WTF@@YAAAJXZ
?tlsKeys@WTF@@YAPAKXZ
?toBoolean@JSString@JSC@@QBE_NPAVExecState@2@@Z
?toInt32@JSC@@YAHN@Z
?toInteger@JSValue@JSC@@QBENPAVExecState@2@@Z
?toNumberSlowCase@JSValue@JSC@@ABENPAVExecState@2@@Z
Expand Down
2 changes: 1 addition & 1 deletion Source/JavaScriptCore/runtime/JSString.h
Expand Up @@ -59,7 +59,7 @@ namespace JSC {

JSString* jsStringBuilder(JSGlobalData*);

class JS_EXPORTCLASS JSString : public JSCell {
class JSString : public JSCell {
public:
friend class JIT;
friend class JSGlobalData;
Expand Down

0 comments on commit 2ce8293

Please sign in to comment.