Skip to content

Commit

Permalink
REGRESSION(267176@main): [Win][Clang] Unreviewed build fix for ALWAYS…
Browse files Browse the repository at this point in the history
…_INLINE_LAMBDA

https://bugs.webkit.org/show_bug.cgi?id=260689

After 267176@main added ALWAYS_INLINE_LAMBDA macro, clang-cl reported
the following warning for Windows port release builds:

> dfg/DFGOperations.cpp(1471,29): warning: unknown attribute 'forceinline' ignored [-Wunknown-attributes]

* Source/WTF/wtf/Compiler.h:
Clang-cl should take the same ALWAYS_INLINE_LAMBDA macro definition with GCC.

Canonical link: https://commits.webkit.org/267471@main
  • Loading branch information
fujii committed Aug 30, 2023
1 parent bac6d73 commit 2f546b2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Source/WTF/wtf/Compiler.h
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@

/* In GCC functions marked with no_sanitize_address cannot call functions that are marked with always_inline and not marked with no_sanitize_address.
* Therefore we need to give up on the enforcement of ALWAYS_INLINE_LAMBDA when bulding with ASAN. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67368 */
#if !defined(ALWAYS_INLINE_LAMBDA) && COMPILER(GCC_COMPATIBLE) && defined(NDEBUG) && !COMPILER(MINGW) && !(COMPILER(GCC) && ASAN_ENABLED)
#if !defined(ALWAYS_INLINE_LAMBDA) && (COMPILER(GCC) || COMPILER(CLANG)) && defined(NDEBUG) && !COMPILER(MINGW) && !(COMPILER(GCC) && ASAN_ENABLED)
#define ALWAYS_INLINE_LAMBDA __attribute__((__always_inline__))
#endif

Expand Down

0 comments on commit 2f546b2

Please sign in to comment.