Stop using CheckedRef with AccessibilityObject

https://bugs.webkit.org/show_bug.cgi?id=266706 rdar://119935028 Reviewed by Brent Fulgham. Stop using CheckedRef with AccessibilityObject. Use WeakRef instead to generate more actionable crashes. * Source/WebCore/accessibility/AccessibilityObject.h: * Source/WebCore/accessibility/AccessibilityTable.cpp: (WebCore::AccessibilityTable::addChildren): Canonical link: https://commits.webkit.org/272358@main
WebKit · Dec 20, 2023 · 3237bcd · 3237bcd
1 parent 6bf65b8
commit 3237bcd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/Source/WebCore/accessibility/AccessibilityObject.h b/Source/WebCore/accessibility/AccessibilityObject.h
@@ -59,7 +59,7 @@ class ScrollableArea;
 
 bool nodeHasPresentationRole(Node*);
 
-class AccessibilityObject : public AXCoreObject, public CanMakeWeakPtr<AccessibilityObject>, public CanMakeCheckedPtr {
+class AccessibilityObject : public AXCoreObject, public CanMakeWeakPtr<AccessibilityObject> {
 public:
     virtual ~AccessibilityObject();
 

diff --git a/Source/WebCore/accessibility/AccessibilityTable.cpp b/Source/WebCore/accessibility/AccessibilityTable.cpp
@@ -46,6 +46,7 @@
 #include "RenderTable.h"
 #include "RenderTableCell.h"
 #include <wtf/Scope.h>
+#include <wtf/WeakRef.h>
 
 #include <queue>
 
@@ -483,7 +484,7 @@ void AccessibilityTable::addChildren()
     RefPtr<HTMLTableCaptionElement> captionElement;
 
     struct DownwardGrowingCell {
-        CheckedRef<AccessibilityTableCell> axObject;
+        WeakRef<AccessibilityTableCell> axObject;
         // The column the cell starts in.
         unsigned x;
         // The number of columns the cell spans (called "width" in the spec).