Skip to content

Commit

Permalink
Make ENABLE_DATE_AND_TIME_INPUT_TYPES a standalone directive
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=267123

Reviewed by Michael Catanzaro.

If it's not a feature it won't end up in scripts that generate C++, as
seen here: https://bugs.webkit.org/show_bug.cgi?id=266947

Furthermore, it not being a feature also caused GTK to ignore a
conditional in html.css. This corrects that and rebases the tests,
creating some more alignment across ports.

As pointed out in https://bugs.webkit.org/show_bug.cgi?id=267080 this
problem is likely to reoccur and might well still be present for other
directives.

* LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt: Removed.
* LayoutTests/platform/gtk/fast/forms/date/date-input-rendering-basic-expected.txt:
* LayoutTests/platform/gtk/fast/forms/date/date-pseudo-elements-expected.txt:
* LayoutTests/platform/gtk/fast/forms/time/time-input-rendering-basic-expected.txt:
* LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt: Removed.
* Source/WTF/wtf/PlatformEnable.h:
* Source/WTF/wtf/PlatformEnableCocoa.h:
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsMac.cmake:
* Source/cmake/WebKitFeatures.cmake:

Canonical link: https://commits.webkit.org/272689@main
  • Loading branch information
annevk committed Jan 5, 2024
1 parent 21dd749 commit 343cc5f
Show file tree
Hide file tree
Showing 10 changed files with 43 additions and 658 deletions.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ layer at (0,0) size 800x600
layer at (0,0) size 800x600
RenderBlock {HTML} at (0,0) size 800x600
RenderBody {BODY} at (8,8) size 784x584
RenderBlock {INPUT} at (0,0) size 94x28 [bgcolor=#FFFFFF] [border: (2px inset #808080)]
RenderText {#text} at (94,11) size 4x17
text run at (94,11) width 4: " "
RenderBlock {INPUT} at (98,0) size 94x28 [bgcolor=#FFFFFF] [border: (2px inset #808080)]
RenderText {#text} at (94,5) size 4x17
text run at (94,5) width 4: " "
RenderText {#text} at (0,0) size 0x0
layer at (8,8) size 94x28 clip at (10,10) size 90x24
RenderFlexibleBox {INPUT} at (0,0) size 94x28 [bgcolor=#FFFFFF] [border: (2px inset #808080)]
layer at (11,11) size 88x22
RenderBlock {DIV} at (3,3) size 88x22
RenderBlock {DIV} at (1,1) size 86x20
Expand All @@ -26,6 +26,8 @@ layer at (11,11) size 88x22
RenderBlock {DIV} at (48,0) size 38x20
RenderText {#text} at (1,1) size 36x17
text run at (1,1) width 36: "1976"
layer at (106,8) size 94x28 clip at (108,10) size 90x24
RenderFlexibleBox {INPUT} at (98,0) size 94x28 [bgcolor=#FFFFFF] [border: (2px inset #808080)]
layer at (109,11) size 88x22
RenderBlock {DIV} at (3,3) size 88x22
RenderBlock {DIV} at (1,1) size 86x20
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ layer at (0,0) size 800x600
layer at (0,0) size 800x600
RenderBlock {HTML} at (0,0) size 800x600
RenderBody {BODY} at (8,8) size 784x584
RenderBlock {INPUT} at (0,0) size 106x29 [bgcolor=#FFFFFF] [border: (2px inset #808080)]
RenderText {#text} at (106,12) size 4x17
text run at (106,12) width 4: " "
RenderBlock {INPUT} at (110,0) size 106x29 [bgcolor=#FFFFFF] [border: (2px inset #808080)]
RenderText {#text} at (106,4) size 4x17
text run at (106,4) width 4: " "
RenderText {#text} at (0,0) size 0x0
layer at (8,8) size 106x29 clip at (10,10) size 102x25
RenderFlexibleBox {INPUT} at (0,0) size 106x29 [bgcolor=#FFFFFF] [border: (2px inset #808080)]
layer at (11,11) size 100x23 clip at (12,12) size 98x21
RenderBlock {DIV} at (3,3) size 100x23 [border: (1px solid #FF0000)]
RenderBlock {DIV} at (2,2) size 96x19
Expand All @@ -26,6 +26,8 @@ layer at (11,11) size 100x23 clip at (12,12) size 98x21
RenderBlock {DIV} at (58,0) size 38x19 [color=#0000FF]
RenderText {#text} at (1,1) size 36x17
text run at (1,1) width 36: "1976"
layer at (118,8) size 106x29 clip at (120,10) size 102x25
RenderFlexibleBox {INPUT} at (110,0) size 106x29 [bgcolor=#FFFFFF] [border: (2px inset #808080)]
layer at (121,11) size 100x23 clip at (122,12) size 98x21
RenderBlock {DIV} at (3,3) size 100x23 [border: (1px solid #FF0000)]
RenderBlock {DIV} at (2,2) size 96x19
Expand Down
Loading

0 comments on commit 343cc5f

Please sign in to comment.