Skip to content

Commit

Permalink
[WPE] Flaky crashes in ScrollingTreeFrameScrollingNodeNicosia::reposi…
Browse files Browse the repository at this point in the history
…tionScrollingLayers

https://bugs.webkit.org/show_bug.cgi?id=213228

Reviewed by Adrian Perez de Castro.

When the `FrameView` delegates scrolling to a native scroll view,
we do not create a dedicated graphics layer for scrolled contents.

In this case, `static_cast<Nicosia::PlatformLayer*>(scrolledContentsLayer())`
evaluates to `nullptr` and we hit the assertion.

* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/wpe/TestExpectations:
* Source/WebCore/page/scrolling/nicosia/ScrollingTreeFrameScrollingNodeNicosia.cpp:
(WebCore::ScrollingTreeFrameScrollingNodeNicosia::repositionScrollingLayers):

Canonical link: https://commits.webkit.org/276274@main
  • Loading branch information
obyknovenius committed Mar 18, 2024
1 parent ee7e9fa commit 35eac71
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
1 change: 0 additions & 1 deletion LayoutTests/platform/glib/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -3859,7 +3859,6 @@ webkit.org/b/169918 compositing/visibility/visibility-image-layers-dynamic.html
webkit.org/b/186667 compositing/repaint/iframes/composited-iframe-with-fixed-background-doc-repaint.html [ Failure Pass ]
# Probably categorized under the wrong bug.
webkit.org/b/212202 compositing/fixed-with-main-thread-scrolling.html [ Timeout ]
webkit.org/b/213228 fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts.html [ Pass Crash ]
compositing/canvas/hidpi-canvas-backing-store-invalidation-2.html [ Failure ]
compositing/canvas/hidpi-canvas-backing-store-invalidation.html [ Failure ]
compositing/canvas/hidpi-canvas-backing-store.html [ Failure ]
Expand Down
3 changes: 0 additions & 3 deletions LayoutTests/platform/wpe/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -233,9 +233,6 @@ http/wpt/mediastream/mediastreamtrackprocessor-videoframe-timestamp.html [ Pass
webkit.org/b/226521 [ Release ] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/source-media-outside-doc.html [ Pass Failure ]
webkit.org/b/226521 [ Debug ] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/source-media-outside-doc.html [ Pass ]

# Nicosia
webkit.org/b/213228 fast/viewport/viewport-1.html [ Crash Timeout Pass ]

# We don't yet support EXIF-based resolution
webkit.org/b/217821 imported/w3c/web-platform-tests/density-size-correction/ [ Skip ]

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,9 @@ void ScrollingTreeFrameScrollingNodeNicosia::currentScrollPositionChanged(Scroll
void ScrollingTreeFrameScrollingNodeNicosia::repositionScrollingLayers()
{
auto* scrollLayer = static_cast<Nicosia::PlatformLayer*>(scrolledContentsLayer());
ASSERT(scrollLayer);
if (!scrollLayer)
return;

auto& compositionLayer = downcast<Nicosia::CompositionLayer>(*scrollLayer);

auto scrollPosition = currentScrollPosition();
Expand Down

0 comments on commit 35eac71

Please sign in to comment.