Skip to content

Commit

Permalink
Consume CA render server sandbox extension earlier
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=269757
rdar://123211653

Reviewed by Brent Fulgham and Chris Dumez.

The sandbox extension needs to be consumed before the drawing area is created.

* Source/WebKit/WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:

Canonical link: https://commits.webkit.org/275018@main
  • Loading branch information
pvollan committed Feb 20, 2024
1 parent 33ccda6 commit 36cd805
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 4 additions & 0 deletions Source/WebKit/WebProcess/WebPage/DrawingArea.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,10 @@ using namespace WebCore;

std::unique_ptr<DrawingArea> DrawingArea::create(WebPage& webPage, const WebPageCreationParameters& parameters)
{
#if PLATFORM(MAC)
SandboxExtension::consumePermanently(parameters.renderServerMachExtensionHandle);
#endif

switch (parameters.drawingAreaType) {
#if PLATFORM(COCOA)
#if !PLATFORM(IOS_FAMILY)
Expand Down
4 changes: 0 additions & 4 deletions Source/WebKit/WebProcess/WebPage/WebPage.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -753,10 +753,6 @@ WebPage::WebPage(PageIdentifier pageID, WebPageCreationParameters&& parameters)
}
#endif

#if PLATFORM(MAC)
SandboxExtension::consumePermanently(parameters.renderServerMachExtensionHandle);
#endif

#if HAVE(STATIC_FONT_REGISTRY)
if (parameters.fontMachExtensionHandles.size())
WebProcess::singleton().switchFromStaticFontRegistryToUserFontRegistry(WTFMove(parameters.fontMachExtensionHandles));
Expand Down

0 comments on commit 36cd805

Please sign in to comment.